Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 237974

Summary: [wikitext] implement a hyperlink detector specifically designed for Java. e.g. detecting org.eclipse.mylyn.internal.java.tasks.JavaClassHyperlinkDetector
Product: z_Archived Reporter: Jingwen 'Owen' Ou <jingweno>
Component: MylynAssignee: Jingwen 'Owen' Ou <jingweno>
Status: RESOLVED DUPLICATE QA Contact:
Severity: normal    
Priority: P3 CC: greensopinion, steffen.pingel
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
screenshot of stack traces in a same line
none
mylyn/context/zip
none
a hyperlink detector specifically designed for Java
none
screenshot of the outcome of hyperlink detector
none
all-in-one patch that fixed the tooltip problem none

Description Jingwen 'Owen' Ou CLA 2008-06-20 14:43:47 EDT 
when stack traces are in the same line (without pressing ENTER), only the first stack trace works, the followed stack traces do not appear to be hyperlinks.
Comment 1 Jingwen 'Owen' Ou CLA 2008-06-20 14:45:13 EDT 
Created attachment 105534 [details]
screenshot of stack traces in a same line

only the first stack trace appear as a hyperlink
Comment 2 Steffen Pingel CLA 2008-06-20 16:47:00 EDT 
Take a look at JavaStackTraceHyperlinkDetector. It might expect line breaks between the stack trace elements.
Comment 3 Steffen Pingel CLA 2008-06-20 16:47:03 EDT 
Created attachment 105546 [details]
mylyn/context/zip
Comment 4 Jingwen 'Owen' Ou CLA 2008-06-20 17:07:15 EDT 
do we need to fix this or just leave it as it is: generating stack trace links with link breaks?
Comment 5 Steffen Pingel CLA 2008-06-20 17:26:33 EDT 
If the use case here is bug 237831 have you considered implementing another hyperlink detector that detects links to files instead of reusing the stack trace detector (which was specifically designed for Java)?
Comment 6 Jingwen 'Owen' Ou CLA 2008-06-20 21:37:53 EDT 
Created attachment 105561 [details]
a hyperlink detector specifically designed for Java

I am not sure where these classes should go. But JavaClassFileHyperlink relies on the org.eclipse.mylyn.java.tasks package, its better for them to go there.
Comment 7 Jingwen 'Owen' Ou CLA 2008-06-20 21:47:46 EDT 
Created attachment 105564 [details]
screenshot of the outcome of hyperlink detector
Comment 8 Jingwen 'Owen' Ou CLA 2008-06-20 21:50:19 EDT 
David, after applying my patch in this bug, the tooltips of the stack trace hyperlinks display a couple of *Unknow Hyperlink*. I think that is related to the bug you fixed. Could you please take a look at it?
Comment 9 Jingwen 'Owen' Ou CLA 2008-06-21 04:03:46 EDT 
Created attachment 105570 [details]
all-in-one patch that fixed the tooltip problem

the problem is caused by a new multiple hyperlink detector introduced in 3.4
Comment 10 Jingwen 'Owen' Ou CLA 2008-06-21 04:17:24 EDT 
**this is the testing comment**

if you can see the following hyperlink and can click to open a java file, congratulations, you did it! :)

org.eclipse.mylyn.internal.java.tasks.JavaClassHyperlinkDetector

**this is the testing comment**
Comment 11 Jingwen 'Owen' Ou CLA 2008-07-01 04:05:13 EDT 

*** This bug has been marked as a duplicate of bug 239087 ***