Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 237546

Summary:

expand new comment when submitting changes to the repository

Product:

z_Archived

Reporter:

Steffen Pingel <steffen.pingel>

Component:

Mylyn

Assignee:

Steffen Pingel <steffen.pingel>

Status:

RESOLVED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

ememberus, mik.kersten

Version:

unspecified

Target Milestone:

3.6

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

Bug Blocks:

248369

Attachments:

Description	Flags
fix	none
mylyn/context/zip	none

Description Steffen Pingel

2008-06-17 17:43:41 EDT

When a task is submitted to the repository the editor does not indicate which changes were submitted to the repository.

Comment 1 Mik Kersten

2010-08-19 01:46:00 EDT

Putting this on the backlog.  I think it's really weird that we don't do this, because a user has to click the collapsed comment to make sure that it submitted.  This is why tools like Gmail do this as well.  It was a part of the original UI design and disappeared.  Is it hard to put back?

Comment 2 Steffen Pingel

2010-08-19 04:20:28 EDT

The delta of changes is currently discarded after a submit expanding comments impacts performance since it requires rendering of additional controls. It shouldn't be overly difficult to implementation though.

Comment 3 Steffen Pingel

2011-02-05 17:06:17 EST

*** Bug 336424 has been marked as a duplicate of this bug. ***

Comment 4 ememberus

2011-02-06 10:40:38 EST

Here is a related issue.
If bugzilla server detects submission errors (like anonymous submission etc.) 
it may return a page that does not clearly indicate that something went wrong 
and submission failed (I already reported this as a separate bug). To avoid 
confusion and repeated submissions in cases when submission succeeded, it 
makes sense (and this is common practice on many sites) to put a bold message
on returned page saying that submission succeeded, something like "your bug report was successfully submitted".

Comment 5 Mik Kersten

2011-05-20 16:38:12 EDT

Fine if this only works for the open task editor (ie, expansion state can be stored in memory).

Comment 6 Steffen Pingel

2011-05-30 17:58:42 EDT

Created attachment 196931 [details]
fix

Comment 7 Steffen Pingel

2011-05-30 17:58:44 EDT

Created attachment 196932 [details]
mylyn/context/zip

Comment 8 Steffen Pingel

2011-05-30 17:58:57 EDT

emeberus, the Task Editor shows a info message in the header if the submission was successful and bright error in case anything goes wrong.

I have now implemented a change that expands the last comment after the submit if a comment was entered.