Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 237211

Summary: [Build Path] Add the option to set variables as include path entry + preferences action
Product: z_Archived Reporter: Roy Ganor <ganoro>
Component: PDTAssignee: PHP UI <php.ui-inbox>
Status: CLOSED FIXED QA Contact: Sylvia Tancheva <silviya>
Severity: major    
Priority: P1 CC: jake.conk, jfalvarez
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 231562, 249459    
Attachments:
Description Flags
patch
none
screen-shot none

Description Roy Ganor CLA 2008-06-15 02:44:48 EDT 
the same bug as Bugzilla #237210

we should take care of it if it is not fixed till the PDT 1.1 release
Comment 1 Roy Ganor CLA 2008-07-13 02:45:28 EDT 
*** Bug 240539 has been marked as a duplicate of this bug. ***
Comment 2 Michael Spector CLA 2008-11-19 11:02:41 EST 
*** Bug 253401 has been marked as a duplicate of this bug. ***
Comment 3 Gadi Goldbarg CLA 2008-11-23 07:31:32 EST 
This bug replaces all similar bugs:

1. Simply go to Windows -> Preferences -> PHP -> Path Variables and try to add 
any path variables. Usually the OK button is disabled even after you filled out 
both variable name and path and the times when you can click OK it doesn't do 
anything.--> doesn't work , null pointer exception

2. Missing The Add variable in Include path page
Comment 4 Roy Ganor CLA 2008-11-25 08:30:25 EST 
let's remove the path variables property page as first step.
Comment 5 Alon Peled CLA 2008-11-26 09:17:19 EST 
commented out the preference page entry. Did not delete, in case we restore it.
Comment 6 Roy Ganor CLA 2008-11-26 15:38:06 EST 
well, we need to implement the php variables now. 
probably will be in the next minor release
Comment 7 Zhongwei Zhao CLA 2010-01-31 04:50:13 EST 
Created attachment 157711 [details]
patch
Comment 8 xu jiaxi CLA 2010-04-21 07:57:46 EDT 
Hi zhao,
There is a compile error after updating from CVS.
This method(SWTUtil.setAccessibilityText) is missing in class FilteredElementTreeSelectionDialog at line 230.
Comment 9 Zhongwei Zhao CLA 2010-05-24 23:46:11 EDT 
Let QA to verify if the behavior is right now.
Comment 10 Sylvia Tancheva CLA 2010-06-07 10:53:30 EDT 
How should variables be displayed when added to include path?
I think that the variable name should be displayed instead of the whole path.
See attachment
Comment 11 Sylvia Tancheva CLA 2010-06-07 10:53:58 EDT 
Created attachment 171277 [details]
screen-shot
Comment 12 Zhongwei Zhao CLA 2010-08-03 00:02:19 EDT 
the original bug has been fixed.

Will create a enhancement for what Silviya suggests.
Comment 13 Sylvia Tancheva CLA 2010-08-31 10:56:47 EDT 
Could not find the mentioned enhancement (not sure it was opened) so I opened a new one: see  Bug 324098

The original bug is fixed so I'm closing it.