Bugzilla – Full Text Bug Listing
| Summary: | [breadcrumb] Breadcrumb misses throwing exception | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Benjamin Muskalla <b.muskalla> | ||||
| Component: | Text | Assignee: | Dani Megert <daniel_megert> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | benno.baumgartner, daniel_megert, markus.kell.r, martinae | ||||
| Version: | 3.4 | Flags: | markus.kell.r:
review+
|
||||
| Target Milestone: | 3.5 M1 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Created attachment 104285 [details]
Fix
Ooops, my fault. This is not the first time that this happens to me. I've filed bug 236385 against JDT/Core to add a compiler warning for this. Use Assert to prevent this problem. I suggest to to fix for 3.5 rather than 3.4.1 (In reply to comment #4) > I suggest to to fix for 3.5 rather than 3.4.1 > Yes, why 3.4.1? No harm done, if you call it twice you probably will get 2 breadcrumbs. >if you call it twice you probably will get 2 breadcrumbs.
Yes, "probably", but you don't know whether this will work at all then. So it's better to make that fix and get feedback in case this really happens.
Fixed in HEAD. Available in builds > N20080708-2000. Fix is good, although not really relevant for 3.4.1. OK, so we have 3 people that don't want/need this for 3.4.1 so let's drop it. |
JDT UI from CVS HEAD as of today (06/10/2008). Just stumbled across EditorBreadcrumb#createContent public Control createContent(Composite parent) { if (fComposite != null) new IllegalArgumentException("Content must only be created once."); //$NON-NLS-1$ There is a "throw" missing in order to achieve the goal.