Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 236033

Summary: [Discovery][SLP] Hide API public method org.eclipse.ecf.provider.jslp.identity.JSLPServiceTypeID.replaceAllIgnoreCase(String, String, String)
Product: [RT] ECF Reporter: Markus Kuppe <bugs.eclipse.org>
Component: ecf.providersAssignee: ecf.core-inbox <ecf.core-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: remy.suen, slewis
Version: 2.0.0   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 233807    
Attachments:
Description Flags
mylyn/context/zip none

Description Markus Kuppe CLA 2008-06-06 08:51:58 EDT 
Accidentally org.eclipse.ecf.provider.jslp.identity.JSLPServiceTypeID.replaceAllIgnoreCase(String, String, String) is marked public although it should have been private. It's nothing bug a helper method for JSLPServiceTypeID.

However this causes org.eclipse.ecf.provider.jslp to be binary incompatible after [1] has been done. To guarantee binary compatibility, we'd have to keep org.eclipse.ecf.provider.jslp.identity.JSLPServiceTypeID.replaceAllIgnoreCase(String, String, String) and let it (optionally) delegate to org.eclipse.ecf.core.util.StringUtils.replaceAllIgnoreCase(String, String, String) until we do 3.0.

To avoid this, I propose to reduce the visibility to private! So how does the PMC approval thingy works?

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=233807

Btw. big thanks to apitools! :)
Comment 1 Scott Lewis CLA 2008-06-06 09:46:03 EDT 
Markus,

RE:  PMC approval...since we don't really have a PMC for ECF, let's just get a +1 from a total of 3 committers...yourself, myself, and one other...so get one other committer to approve the change here.

Here's mine:

+1
Comment 2 Remy Suen CLA 2008-06-06 09:57:26 EDT 
Sounds reasonable to me, +1.
Comment 3 Markus Kuppe CLA 2008-06-06 10:01:13 EDT 
Due to 3 positive votes (including myself), this has been FIXED in Revision_2_0. Obviously no forward port to HEAD is needed.
Comment 4 Markus Kuppe CLA 2008-06-06 10:01:18 EDT 
Created attachment 103950 [details]
mylyn/context/zip