Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 235789

Summary: key binding for "Open Repository Task" doesn't work
Product: z_Archived Reporter: Tomasz Zarna <tomasz.zarna>
Component: MylynAssignee: Steffen Pingel <steffen.pingel>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: P4 CC: eclipse, steffen.pingel
Version: devKeywords: helpwanted
Target Milestone: 3.0.2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch
none
mylyn/context/zip
none
mylyn/context/zip none

Description Tomasz Zarna CLA 2008-06-05 05:53:13 EDT
Steps:
1. Open Task Repositories view
2. Right click on a repository
3. Observe that the context menu shows a key binding for "Open Repository Task..." action. In my case it's Ctrl+Shift+Alt+F12, I guess it's there by default.
4. Try to trigger the action using the binding from 3.
=> No result, nothing happens :/
Comment 1 Steffen Pingel CLA 2008-06-05 18:40:29 EDT
I can not test this since Ctrl+Alt+F12 is handled by my operating system. Over to you Mik.
Comment 2 Mik Kersten CLA 2008-06-12 12:22:18 EDT
It's bound on my system as well (to some esoteric Logitech keyboard feature).  However, I don't think that's the problem, because if I enable the "Mylyn/Task Navigation Extras" action set, I will get both the dialog (expected behavior) and the popup.  

Thomasz: you should see this as well.  So the remaining problem is to ensure that the shortcut does not show up when the action set is not enabled.
Comment 3 Tomasz Zarna CLA 2008-07-02 05:46:38 EDT
Affirmative, with the action set enabled I'm able to open the dialog with the shortcut.
Comment 4 Steffen Pingel CLA 2008-07-03 19:29:53 EDT
The key-binding should be handled by a command that is not coupled to the action set. Frank, would you be interested in contributing a fix for this?
Comment 5 Frank Becker CLA 2008-07-24 16:48:54 EDT
Created attachment 108396 [details]
patch
Comment 6 Frank Becker CLA 2008-07-24 16:48:58 EDT
Created attachment 108397 [details]
mylyn/context/zip
Comment 7 Steffen Pingel CLA 2008-08-03 16:37:32 EDT
Frank, I would prefer a solution that implements the action as a command rather than enabling an infrequently used action set which clutters the UI. Let me know if you are interested in providing a patch for that.
Comment 8 Steffen Pingel CLA 2008-08-03 23:21:33 EDT
Fixed in >I20080803-0500. The command now has a default handler.
Comment 9 Steffen Pingel CLA 2008-08-03 23:21:36 EDT
Created attachment 109041 [details]
mylyn/context/zip
Comment 10 Frank Becker CLA 2008-08-03 23:30:46 EDT
(In reply to comment #7)
> Frank, I would prefer a solution that implements the action as a command rather
> than enabling an infrequently used action set which clutters the UI. Let me
> know if you are interested in providing a patch for that.

Hi Steffen,

what is the timeframe for doing this?
Actually I look what I can fix for bug#242480 (port Bugzilla tests to Myly 3.0 framework).

Comment 11 Steffen Pingel CLA 2008-08-04 00:27:22 EDT
This bug should be fixed now. It turned out straight forward. Any help you can provide in resolving bug 242480 is greatly appreciated.