Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 234484

Summary: [DetachedView] Empty DW's can't be closed
Product: [Eclipse Project] Platform Reporter: Eric Moffatt <emoffatt>
Component: UIAssignee: Eric Moffatt <emoffatt>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 3.4   
Target Milestone: 3.4.1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 244957    
Attachments:
Description Flags
Adds code that explicitly removes the DW from the layout none

Description Eric Moffatt CLA 2008-05-28 15:49:06 EDT 
When checking the fix for bug 218197 I noticed that if the view that goes away is the only view in a Detached Window stack then on the restart you get an 'empty' DW.

While you can hit the red 'x' and have the shell go away it'll reappear if you switch out of the perspective and back again.

The problem seems to be that the control for removing a DW from the ShellPool is handled in the 'hideView' command (so it never gets invoked if the stack has no views).

The more general issue is that the close handling code seems to want to handle everything in 'hideView' (that's also where the prompting to save dirty views was as well. We have another defect against our fix for that...
Comment 1 Eric Moffatt CLA 2008-05-28 15:50:58 EDT 
See Bug 232556 for another 'hideView' issue.

Marking for 3.4.1
Comment 2 Eric Moffatt CLA 2008-08-07 22:09:35 EDT 
Created attachment 109488 [details]
 Adds code that explicitly removes the DW from the layout


This code is only invoked when closing a DW that has no visible views (a rare case resulting from a DW containing a single view that becomes 'unavailable' due to it simplementation bundle going away).
Comment 3 Eric Moffatt CLA 2008-08-07 22:18:42 EDT 
Committed (to R3_4_maintenance) in >20080807. Closed DW's now stay closed.
Comment 4 Eric Moffatt CLA 2008-08-07 22:24:11 EDT 
Fixed in 3.4.1, reopen for 3.5 for a better solution...
Comment 5 Eric Moffatt CLA 2008-08-21 14:23:16 EDT 
Verified in M20080820-0800.