Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 233426

Summary:

Lots of new API errors after switching to I20080521-2000

Product:

[Eclipse Project] PDE

Reporter:

Dani Megert <daniel_megert>

Component:

API Tools

Assignee:

Olivier Thomann <Olivier_Thomann>

Status:

VERIFIED FIXED

QA Contact:

Severity:

major

Priority:

CC:

darin.eclipse, Michael_Rennie, Olivier_Thomann

Version:

3.4

Flags:

Olivier_Thomann: review+
Michael_Rennie: review+

Target Milestone:

3.4 RC2

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
patch	none

Description Dani Megert

2008-05-22 06:59:15 EDT

I20080521-2000

After switching to I20080521-2000 I now have tons of these:
- The super interfaces set has been reduced for type ...
- The superclass set has been reduced for type ...

And due to those errors it also creates an error in the manifest:
- The major version should be incremented in version 3.4.0.qualifier, since API breakage occurred since version 3.3.1.r331_v2007062


Neither restart nor full build fixes it. No problems in I20080520-2000 or RC1.

Test Case:
1. start fresh workspace using I20080521-2000
2. set R3.3.1.1 as API baseline
3. checkout 'org.eclipse.jface.text' from CVS
==> lots of errors

Comment 1 Darin Wright

2008-05-22 09:40:52 EDT

I only see one error:

Missing @since tag on org.eclipse.jface.text.contentassist.ContentAssistant.AutoAssistListener	

This class moved from default to protected in 3.4 so it is now API and should have a since tag.

Comment 2 Darin Wright

2008-05-22 09:43:58 EDT

(Note: I'm using 3.3.2 as a baseline, will try 3.3.1.1)

Comment 3 Dani Megert

2008-05-22 09:48:07 EDT

Ah, missed one important step: import all required plug-ins of jface.text as binary projects.

Comment 4 Dani Megert

2008-05-22 09:50:32 EDT

With that additional info it is 100% reproducible on my side.

Comment 5 Olivier Thomann

2008-05-22 09:54:25 EDT

I am investigating it. Trying to reproduce first.

Comment 6 Olivier Thomann

2008-05-22 09:56:38 EDT

Did the same steps work fine in previous builds ?

Comment 7 Olivier Thomann

2008-05-22 10:02:21 EDT

Reproduced. Investigating.

Comment 8 Dani Megert

2008-05-22 10:06:05 EDT

>Did the same steps work fine in previous builds ?
Yes, if I go back to I20080520-2000 and clean jface.text and rebuild then the errors go away. If I go to latest build clean and rebuild they come back. Note that these steps are done without changing the set of imported plug-ins.

Comment 9 Olivier Thomann

2008-05-22 10:23:15 EDT

The profile contains twice swt: org.eclipse.swt_3.3.2.v3347 and org.eclipse.swt_3.4.0.v3445b.
So they are two problems here:
1) swt should only be there once
2) regardless of which one is selected, both should be able to resolve types in it.

Comment 10 Olivier Thomann

2008-05-22 11:11:13 EDT

Ok, forget point (1).
For (2) the problem came from the fact that swt was not considering its fragments when loaded in the workbench.

Comment 11 Darin Wright

2008-05-22 11:12:02 EDT

Created attachment 101524 [details]
patch

Problem is with the way SWT is considered in the workspace. The fix for bug 232958 caused this. When SWT is a project in the workspace, it's class files are in the SWT host project. When SWT is a binary bundle, it's class files are in its platform specific fragment. So, we need to adjust accordingly.

Comment 12 Olivier Thomann

2008-05-22 11:25:34 EDT

+1 for RC2.

Comment 13 Michael Rennie

2008-05-22 12:09:56 EDT

applied patch

Comment 14 Michael Rennie

2008-05-22 12:10:10 EDT

verified