Bugzilla – Full Text Bug Listing
| Summary: | P2Installer doesn't work on a Mac | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Alex Blewitt <alex.blewitt> | ||||
| Component: | Releng | Assignee: | Kim Moir <kim.moir> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | critical | ||||||
| Priority: | P3 | CC: | aniefer, jeffmcaffer, kim.moir, pascal, tjwatson, wong | ||||
| Version: | 3.4 | Flags: | pascal:
review+
tjwatson: review+ jeffmcaffer: review+ |
||||
| Target Milestone: | 3.4 RC3 | ||||||
| Hardware: | Macintosh | ||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | 234032 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Alex Blewitt
Ben, Jeff, could you please investigate. I think the installer from http://download.eclipse.org/eclipse/equinox/drops/S-3.4RC1-200805161333/index.php#Provisioning wasn't built properly. I checked out the installer code and ran it, it worked fine. I exported it using the export wizard and ran it, it worked fine. The p2installer.ini that I exported was different, it only had: -vmargs -Dorg.eclipse.equinox.p2.installDescription=http://download.eclipse.org/eclipse/testUpdates/sdk-installer.properties yeah, hte instlaler on the download site clearly has the .ini file from the SDK not one that is appropriate for the installer. It is not clear how the installer is being built. If it is via some sort of product export/build then there may well be a bug in pde build as the product file has the right markup and exporting from the workspace on a Mac works fine. Alternatives: - there may be a whacky build story for the installers and somehwo it is out of date (note that I believe that previous versions of the Mac installer worked) - there may be an issue with crossplatform build and/or deltapacks. I don't know why this is happening since the org.eclipse.equinox.p2.installer\installer.product specifies the vm arguments for all the drops. All three installer platforms are built in the same way. Andrew do you have any ideas? Depending on how the metadata is being generated for the installer, this could be caused by bug 222126. This could be the problem if the metadata is being generated by running the generator over the built installer product (like the old style p2 build did for sdk). The fix would be some variation on providing the .product file to the generator or generating the metadata through the pde.build integration like the sdk does. I will take a look on Monday. the problem still occurs in RC2. Just get the installer download and look in the p2installer.ini file to see the incorrect content. Created attachment 102049 [details] workaround patch caused by bug 234032. Patch is a workaround. I hacked the test build that I'm running now for bug 224278 to include this fix as well. Test build was successful, thanks Andrew. Jeff, Pascal, Tom, please +1 for inclusion in RC3. Teh patch itself looks fine. Some related questions: - is the workaround sufficient for 3.4? - Will others run into the same problem? - Is there something that needs to go in a migration guide etc? +1, but please confirm my understanding of the patch. It simply deletes the incorrect eclipse.ini file from the executable feature from the collectingFolder before the files from the collectinFolder are added to the installer. This prevents the good eclipse.ini from getting overwritten in the installer. Correct? regarding comment #11, yes Tom this is correct (In reply to comment #10) > Teh patch itself looks fine. Some related questions: > - is the workaround sufficient for 3.4? > - Will others run into the same problem? > - Is there something that needs to go in a migration guide etc? > I will fix bug 234032 so others won't have the same problem. I think the workaround is a good idea so that Kim does not have to wait for the fix and then update her basebuilder this close to release. (In reply to comment #11) > +1, but please confirm my understanding of the patch. It simply deletes the > incorrect eclipse.ini file from the executable feature from the > collectingFolder before the files from the collectinFolder are added to the > installer. This prevents the good eclipse.ini from getting overwritten in the > installer. Correct? > Just to clarify, at the time this delete runs, the collectingFolder looks something like: Eclipse.app/Contents/MacOS/eclipse Eclipse.app/Contents/MacOS/eclipse.ini p2installer.app/Contents/MacOS/p2installer.ini Immediately after this, the pde.build branding task is going to rename the "eclipse" launcher to "p2installer" and move it over to the p2installer.app. Similarly for the .ini which ends up overwriting the correct p2installer.ini released for I20080528-2000. |