Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 233111

Summary:

[expressions] Changing an expression name in the view should not accept an empty expression

Product:

[Tools] CDT

Reporter:

Marc Khouzam <marc.khouzam>

Component:

cdt-debug-dsf

Assignee:

Marc Khouzam <marc.khouzam>

Status:

CLOSED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

cdtdoug, dd.general-inbox, pawel.1.piech

Version:

0 DD 1.1

Flags:

cdtdoug: iplog-

Target Milestone:

DD 1.1

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Patch with fix.	cdtdoug: iplog-

Description Marc Khouzam

2008-05-20 20:29:51 EDT

In the expressions view, it is possible to click on an expression and edit it.
If the user puts in a blank expression, this is currently accepted, which will of course fail in GDB.
I suggest that if the expression is blank, the old expression should be put back, is if we pressed ESC

Comment 1 Pawel Piech

2008-05-21 12:51:28 EDT

Agreed!

Comment 2 Pawel Piech

2008-10-09 01:33:45 EDT

Created attachment 114640 [details]
Patch with fix.

This fix actually removes the expression instead of just ignoring the user input.

Comment 3 Pawel Piech

2008-10-09 01:34:46 EDT

Fix committed.  Marc, please verify.

Comment 4 Marc Khouzam

2008-10-09 10:46:00 EDT

Great!
Verified

Comment 5 Pawel Piech

2009-01-07 15:57:00 EST

DD 1.1 reelased!