Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 233052

Summary: Shared bundle pool shows up as non-system repository
Product: [Eclipse Project] Equinox Reporter: John Arthorne <john.arthorne>
Component: p2Assignee: Simon Kaegi <simon_kaegi>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: simon_kaegi, susan
Version: unspecifiedFlags: john.arthorne: review+
susan: review+
Target Milestone: 3.4 RC2   
Hardware: PC   
OS: Windows Vista   
Whiteboard:
Attachments:
Description Flags
patch none

Description John Arthorne CLA 2008-05-20 15:51:35 EDT
Build: 3.4 RC1

Running in shared install mode on Vista (running as non-administartor with eclipse installed under Program Files). I see the location of the shared bundle pool as an available repository in the UI. This should be marked as a system repository.
Comment 1 Simon Kaegi CLA 2008-05-21 14:08:51 EDT
Created attachment 101328 [details]
patch

There shouldn't be a metadata repo like this being added at all. We're broadcasting the wrong type of event in the ArtifactRepositoryManager.
Comment 2 John Arthorne CLA 2008-05-21 14:13:17 EDT
Adding Susan as second reviewer since UI is the one listening to these events and has the most potential for impact.
Comment 3 Susan McCourt CLA 2008-05-21 18:21:02 EDT
Ran the code and I verified that the bundle pool is gone with the fix.
I had seen this symptom in a non-shared install but had thought it was added because of some secret repo I didn't know about in the reconciler.

From a UI point of view, it can only help to reduce the number of metadata events that come in, so I don't see how this can harm me.  In fact I'm pretty sure this caused bug #231968.
Comment 4 Simon Kaegi CLA 2008-05-21 18:24:21 EDT
Released.