Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 232891

Summary: TVT34:TCT412: JA: Validator names in English in preferences panel
Product: [WebTools] JSDT Reporter: CDE Administration <cdeadmin>
Component: GeneralAssignee: Bradley Childs <childsb>
Status: CLOSED FIXED QA Contact: Phil Berkland <berkland>
Severity: major    
Priority: P3 CC: camle, childsb, david_williams, hjzhang, kaloyan, kitlo, konstantin, neil.hauge
Version: 3.0Flags: david_williams: pmc_approved+
childsb: pmc_approved? (raghunathan.srinivasan)
childsb: pmc_approved? (naci.dai)
childsb: pmc_approved? (deboer)
neil.hauge: pmc_approved+
kaloyan: pmc_approved+
berkland: review+
Target Milestone: 3.0 RC4   
Hardware: PC   
OS: Linux-GTK   
URL: 412
Whiteboard: PMC_approved
Attachments:
Description Flags
3.003830.gif
none
validExtern.JPG
none
patch to externalize the javascript validator name
childsb: review+
TCT412_0603.gif none

Description CDE Administration CLA 2008-05-19 23:17:20 EDT
<response_by> Eriko Takahashi at 2008.05.19.15.40.22 </response_by>
OS: Linux
Build date: 0518
Component/Functoin name:WTP
Blocking:NO
Language: Japanese
Tester Name: Eriko Takahashi
Testcase: 3.003830

Steps to recreate the problem:
1. ?Window? -> ?Preferences?
2.  click on the ?Validation? node

Problem description:
In the Validation preferences panel, the following validators are shown in English:
- JavaScript Syntax Validator
- ModuleCore Validator

I am not able to find those strings in our files.

Please investigate.

Thank you.
Eriko Takahashi

<response_by> John Ryding at 2008.05.19.22.02.42 </response_by>
These strings are not externalized in our mock english build.

<response_by> John Ryding at 2008.05.19.22.03.10 </response_by>
This article was reassigned from Category:''TVT/Testing,Inbox''.
Comment 1 CDE Administration CLA 2008-05-19 23:17:26 EDT
Created attachment 100992 [details]
3.003830.gif
Comment 2 CDE Administration CLA 2008-05-19 23:17:29 EDT
Created attachment 100993 [details]
validExtern.JPG
Comment 3 CDE Administration CLA 2008-05-19 23:17:34 EDT
<cde:tctdetail>
Testcase: 3.003830
Project: WSW34
Component: Xfer - Web Tools/wst.jsdt
Priority: 3
Subject: JA: Validator names in English in preferences panel
Article ID: 412
Originator: ERIKOT@jp.ibm.com
</cde:tctdetail>
Comment 4 Bradley Childs CLA 2008-05-21 16:04:05 EDT
Created attachment 101370 [details]
patch to externalize the javascript validator name
Comment 5 Bradley Childs CLA 2008-05-21 16:06:05 EDT
PMC - this is trivial string change.
Comment 6 Kaloyan Raev CLA 2008-05-22 07:45:08 EDT
Approved for the "JavaScript Syntax Validator" patch.

This bug addresses also another string that is not externalized:
- ModuleCore Validator

I thihk that after committing the patch, the bug should be moved to wst.common for further processing. 
Comment 7 CDE Administration CLA 2008-05-22 10:49:26 EDT
<response_by> Stepan Kvapilik at 2008.05.22.09.38.46 </response_by>
Hallo, I have the same problem here in Czech. These strings should be externalized.
Jiri
Comment 8 Bradley Childs CLA 2008-05-22 16:33:52 EDT
fixed JSDT portion.
Comment 9 CDE Administration CLA 2008-05-29 17:49:04 EDT
<response_by> YoungSun Ko at 2008.05.29.16.29.45 </response_by>
Same for Korean.

Thanks,
Youngsun
Comment 10 CDE Administration CLA 2008-06-04 15:20:11 EDT
<response_by> Eriko Takahashi at 2008.06.04.13.54.28 </response_by>
Hi

With 0603 build, "ModuleCore Validator" is still shown in English.
Please investigate.

Thank you.
Eriko Takahashi
Comment 11 CDE Administration CLA 2008-06-04 15:20:15 EDT
Created attachment 103627 [details]
TCT412_0603.gif
Comment 12 David Williams CLA 2008-06-04 16:10:52 EDT
Note: I've opened bug 235695 so hopefully long term, these type of errors will be easier to find earlier in the process. 

Comment 13 Bradley Childs CLA 2008-06-04 16:13:01 EDT
re-assigning to wst-common.
Comment 14 David Williams CLA 2008-06-04 23:24:02 EDT
You don't get out of it that easily Bradley. :) 

Since _this_ fix is in 
org.eclipse.wst.jsdt.web.core 
then it is to stay in the jsdt component, and you should commit and release this change. 

bug 235695 is in 'common' component, since that fix is in validator code. 

Thanks, 
Comment 15 Bradley Childs CLA 2008-06-05 12:26:50 EDT
Hi David, sorry my mistake on transferring.

The JSDT portion of this bug is fixed/released.  There is a second validator name externalization "ModuleCore Validator" mentioned in the problem description that is not coming from JSDT.  

I didn't realize that bug 235695 addressed the other validator name externalization issue.  Since the JSDT piece is resolved in current builds (and verified) I'll close this bug.

-Brad
Comment 16 CDE Administration CLA 2008-06-06 12:17:08 EDT
<response_by> Stepan Kvapilik at 2008.06.06.11.07.16 </response_by>
Hi, problem still there, hopefully these strings will be added to next Monday's shipment...

Jiri
Comment 17 CDE Administration CLA 2008-06-06 16:20:56 EDT
<response_by> Eriko Takahashi at 2008.06.06.15.02.16 </response_by>
Hi

"JavaScript Syntax Validator" is fixed.

I opend TCT 758 for ModuleCore Validator.

Thanks!

Eriko Takahashi