Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 231283

Summary: [hovering] Cannot tab back to browser in BrowserInformationControl on WinXP
Product: [Eclipse Project] Platform Reporter: Markus Keller <markus.kell.r>
Component: TextAssignee: Markus Keller <markus.kell.r>
Status: RESOLVED WORKSFORME QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert
Version: 3.4   
Target Milestone: 3.4 RC1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 231303    
Bug Blocks:    
Attachments:
Description Flags
Workaround using display filter none

Description Markus Keller CLA 2008-05-09 07:35:32 EDT 
I20080508-2000, already an issue in M5

In a sticky Javadoc hover, the Tab key eventually brings focus to the toolbar. When I press Tab once more, the focus ends up in the Browser control (not in the WebSite control where it usually is when the browser has focus).

I tried to reproduce in an SWT snippet, but there it worked fine.
Comment 1 Markus Keller CLA 2008-05-09 10:32:13 EDT 
See bug 231303 and bug 231311. Workaround might be to change BrowserInformationControl to use a display filter to capture the Esc key.
Comment 2 Markus Keller CLA 2008-05-09 14:18:44 EDT 
Created attachment 99530 [details]
Workaround using display filter
Comment 3 Markus Keller CLA 2008-05-09 15:40:52 EDT 
Tagging for RC1, since we need this unless the blocking bugs get fixed.
Comment 4 Dani Megert CLA 2008-05-13 04:55:07 EDT 
Will review if we don't get a fix for 231311 until Friday.
Comment 5 Markus Keller CLA 2008-05-13 08:21:32 EDT 
Comment on attachment 99530 [details]
Workaround using display filter

The fix for bug 231303 made this workaround obsolete.

If bug 231311 is fixed, we can remove the KeyListener in HEAD of BrowserInformationControl. Otherwise, we keep the current code (same as in 3.3).
Comment 6 Dani Megert CLA 2008-05-13 08:33:11 EDT 
Marking as WORKSFORME since this now works due to the fix for bug 231303.

Filed bug 231788 for the key listener removal.