Bugzilla – Full Text Bug Listing
| Summary: | Pallette Tool Description strings not externalized | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] GEF | Reporter: | John Ryding <trippinbilly25> | ||||
| Component: | GEF-Legacy GEF (MVC) | Assignee: | Anthony Hunter <ahunter.eclipse> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | ahunter.eclipse, hudsonr, ppshah | ||||
| Version: | unspecified | ||||||
| Target Milestone: | 3.4.0 (Ganymede) RC2 | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
The error message is only shown when using "*" in the Logic Editor Example. This string is not translated. In fact, GMF, which has adopted the PaletteCustomizer, allows the drawer name to contain "*", so I am not sure why the message is even there. It is likely simply there as a code example to demonstrate how to implement the PaletteCustomizer. I think I had added that just to test out the error message support. Must've unintentionally released that change. (In reply to comment #2) > I think I had added that just to test out the error message support. Must've > unintentionally released that change. > We need to remove this code, it is confusing the translators. > We need to remove this code, it is confusing the translators.
Is the logic example even translated? If not, we would eventually remove all of the function in the logic example so that there are no untranslated strings. It seems like someone needs to either translate the example, or find some other way to verify that GEF itself is properly translated.
> I think I had added that just to test out the error message support. Must've
> unintentionally released that change.
If the code is in the example and not GEF, I don't think this was unintentional.
(In reply to comment #3) > > We need to remove this code, it is confusing the translators. > Ok then, forget I said this, change this to: We need to remove this code, since a string containing "*" is a valid use case. It is confusing to display an error in the examples when in fact there is nothing wrong and the string is valid. > We need to remove this code, since a string containing "*" is a valid use case.
> It is confusing to display an error in the examples when in fact there is
> nothing wrong and the string is valid.
This is just an whimsical restriction imposed by the *example*, not by GEF. The only reason it is there is to test the accessibility of the error message and that the label appears when asked to. In a real-world scenario, someone might be creating a custom entry which requires some additional, domain-specific parameters to be set.
Maybe the message could be changed to say "The Logic Example prohibits the character '*'"? (In reply to comment #7) > This is just an whimsical restriction imposed by the *example*, not by GEF. The > only reason it is there is to test the accessibility of the error message and > that the label appears when asked to. In a real-world scenario, someone might > be creating a custom entry which requires some additional, domain-specific > parameters to be set. > Yeah, you're right. Now I remember. :) Sorry about all the confusion. I believe the logic example IS translated (for testing purposes). If that is true, the original problem is valid: this string needs to be translated, but is not. (In reply to comment #8) > Maybe the message could be changed to say "The Logic Example prohibits the > character '*'"? > Good idea. This is what we can do. (In reply to comment #9) > > I believe the logic example IS translated (for testing purposes). If that is > true, the original problem is valid: this string needs to be translated, but is > not. > The examples are not translated. (In reply to comment #6) > > We need to remove this code, since a string containing "*" is a valid use case. > It is confusing to display an error in the examples when in fact there is > nothing wrong and the string is valid. > committed to HEAD. |
Created attachment 98428 [details] Screenshot of the error Build ID: I20080421 Steps To Reproduce: Steps To Reproduce: 1.Download GEF examples 2.Create a general project 3.Right click on your general project New > Example > GEF > Logic Diagram 4. Window > Show View > Other > Gerneral > Pallette 5. Right Click in the Pallette, click on Customize 6. Click on Component 7. Click in the "Name" box, add a * to the end of "Components" More information: The error message that appears at the top of the window should be externalized for translation, but it does not appear to be so. In the screen shot I attached, the error should look more along the lines of the other bolded and expanded strings in the window that are circled in blue.