Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 229354

Summary: [ui] No progress when reverting
Product: [Eclipse Project] Equinox Reporter: Pascal Rapicault <pascal>
Component: p2Assignee: Susan McCourt <susan>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: simon_kaegi, susan
Version: 3.4   
Target Milestone: 3.5 M5   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Pascal Rapicault CLA 2008-04-29 11:17:45 EDT
I20080429
When a revert is happening, the dialog is grayed out and no sign of progress is being reported to the user. We should try to have a visual cue that things are happening.
Comment 1 Susan McCourt CLA 2008-04-29 11:31:13 EDT
consider for 3.4
Comment 2 Susan McCourt CLA 2008-05-14 13:01:46 EDT
bulk update - p2 UI bugs marked 3.4 are now marked 3.4 RC2.  These are substantial enough that if they don't get in for RC2, they shouldn't go in.
Comment 3 Susan McCourt CLA 2008-05-15 20:29:32 EDT
given the number of bugs in the UI currently tagged RC2, I'm removing the milestone for some that are not required and would not be justifiable to be fixed after RC2.
Comment 4 Susan McCourt CLA 2008-12-10 13:34:12 EST
My plan here is to follow the same workflow as the other operations for revert.  The revert will run in the background, with progress reported as for other operations.  The user will be prompted to restart afterward (without the option to apply changes).

This also sets us up nicely if we decide to show the revert history in an installation page (bug 216031).
Comment 5 Susan McCourt CLA 2008-12-10 13:36:50 EST
(In reply to comment #4)
> My plan here is to follow the same workflow as the other operations for revert.
>  The revert will run in the background, with progress reported as for other
> operations.  The user will be prompted to restart afterward (without the option
> to apply changes).
> 
> This also sets us up nicely if we decide to show the revert history in an
> installation page (bug 216031).
> 

I see now Pascal suggested this very same thing as bug #233069, so it only took 7 months for me to agree with him.
Comment 6 Susan McCourt CLA 2009-01-07 18:58:39 EST
Fixed in HEAD >20090107.
There are two different progress things shown now.

A progress dialog is shown while the revert plan is being computed.  The user can cancel this.  If the plan successfully computes, then a revert operation is started as a background job, which shows the jobs progress monitor the same as any other install/uninstall/update operations.