Bugzilla – Full Text Bug Listing
| Summary: | [presence][ui] xmpps accounts can appear twice in contacts list | ||
|---|---|---|---|
| Product: | [RT] ECF | Reporter: | Scott Lewis <slewis> |
| Component: | ecf.presence | Assignee: | Scott Lewis <slewis> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | mauromol, remy.suen, torkildr |
| Version: | 1.2.0 | Keywords: | helpwanted |
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Scott Lewis
(In reply to comment #0) > 1) removing retrieveServices() (but would this have other negative side > effects?) > 2) Adding a check in addContainer for the prior existence of a given container > and not adding it if already present? We'd have to go with 2. We implemented retrieveServices() so that people that closed the 'Contacts' view didn't magically end up disconnecting as it's not uncommon for people to only have IM windows open but their buddy list minimized. OK, I'll implement strategy 2 from the description. Fixed in HEAD. Unfortunately, we now have the opposite problem. It's now possible that the contacts list will be opened upon successful connection of a container, but the roster will not be populated or displayed...and nothing is shown in the Contacts list. I'm not sure why this is. Remy any thoughts? (In reply to comment #4) > Unfortunately, we now have the opposite problem. It's now possible that the > contacts list will be opened upon successful connection of a container, but the > roster will not be populated or displayed...and nothing is shown in the > Contacts list. > > I'm not sure why this is. Remy any thoughts? > Fixed (committed to HEAD) by adding check for 0 accounts in createPartControl i.e. if (rosterAccounts.size() == 0) pageBook.showPage(helpMessageLabel); I'm using ECF 3.0.1 and I do have the Contacts view with the same contact shown two or more times... It seems that if I do the following: - add a contact - the other contact receives the authorization request and accepts - the Contacts view shows the new contact - the other contact sends me the authorization request - I accept the authorization request - the Contacts view shows the new contact another time! Every time a contact asks me for authorization, it is added in the contacts view, whether or not it is already in there... Is it normal? Hi Mauro, A couple of questions: Is this ECF 3.1, or 3.0.1? If you really are using 3.0.1 would you be able to try 3.1? What is the xmpp server/service is being used (i.e. gmail, wildfire, jabber, etc?) If you exit ECF (and Eclipse) and then reconnect, is the contact their twice? Do *both* accounts show two contacts, or just the one that auth request initiator? Since ECF 3.1 (Oct 2009) we've moved over to a new version of the Smack library (Smack 3.1 rather than 2.2). Would you possibly be able/willing to work with the code from HEAD in the ECF CVS server? Thanks. (In reply to comment #6) > I'm using ECF 3.0.1 and I do have the Contacts view with the same contact shown > two or more times... It seems that if I do the following: > - add a contact > - the other contact receives the authorization request and accepts > - the Contacts view shows the new contact > - the other contact sends me the authorization request > - I accept the authorization request > - the Contacts view shows the new contact another time! > > Every time a contact asks me for authorization, it is added in the contacts > view, whether or not it is already in there... > > Is it normal? (In reply to comment #7) > Is this ECF 3.1, or 3.0.1? If you really are using 3.0.1 would you be able to > try 3.1? I'm using 3.0.1. I may try 3.1. > What is the xmpp server/service is being used (i.e. gmail, wildfire, jabber, > etc?) A LAN Openfire 3.6.4 installation. > If you exit ECF (and Eclipse) and then reconnect, is the contact their twice? No. After restarting Eclipse, I see each contact just once. > Do *both* accounts show two contacts, or just the one that auth request > initiator? Well, I don't know if I understood your question correctly. In my case, the other accounts were using clients that are not ECF (i.e.: Pidgin, Openfire). But it may be useful for you to know that if another client requested the authorization to me before I did to him/her, the incoming contact was not shown more than once. The problem appeared when I was the first one to add the contact and request the authorization. > Since ECF 3.1 (Oct 2009) we've moved over to a new version of the Smack library > (Smack 3.1 rather than 2.2). Would you possibly be able/willing to work with > the code from HEAD in the ECF CVS server? Well, it would be much simpler if the ECF 3.1 packages were in the weekly update site. I'll have a look. Anyway, in ECF 3.0.1 I noticed many other small annoyances while using the Contacts view to manage XMPP contacts. But maybe I should better write in the newsgroup for these. I just realized that ECF 3.1 has been released in December, but I hadn't it installed because I didn't have the ECF update site in my Eclipse installation. I'm upgrading right now, I'll let you know. (In reply to comment #9) > I just realized that ECF 3.1 has been released in December, but I hadn't it Actually, it has been released in October... :-) Anyway, I installed ECF 3.1.0.v20091012-1618. I tried to remove one of my contacts in order to try to re-add it again and see if the problem still exists. However, when I right-click on a contact and select "Remove", nothing happens... the contact is not removed from the Contacts view. (In reply to comment #10) > Anyway, I installed ECF 3.1.0.v20091012-1618. I tried to remove one of my > contacts in order to try to re-add it again and see if the problem still > exists. However, when I right-click on a contact and select "Remove", nothing > happens... the contact is not removed from the Contacts view. I think this is another bug... After doing this, I tried to click on "Connect to provider" and set up the same connection. Another connection to the same account appeared in the Contacts view, before the first one. The new connection doesn't show the accounts I tried to "remove" before... while first connection does!! To be more precise, I have: - myaccount@myserver:port - contact 1 (offline) - contact 2 (although I have clicked on remove!) - contact 3 - contact 4 (althuogh I have clicked on remove!) - contact 5 (offline) - myaccount@myserver:port (added when I created the second connection to the same account) - contact 1 (offline) - contact 3 - contact 5 (offline) So, it seems to be a view refresh problem. Given this, on the second connection I tried to add again the contact 4... and it now shows twice. The first time it appears is when the other side accepts my authorization request and the second time it appears when I give my authorization for him to add myself to his list. So, after this process, my Contacts view now shows: - myaccount@myserver:port - contact 1 (offline) - contact 2 (although I have clicked on remove!) - contact 3 - contact 4 (althuogh I have clicked on remove!) - contact 5 (offline) - myaccount@myserver:port - contact 1 (offline) - contact 3 - contact 5 (offline) - contact 4 (added when the other side accepted my request) - contact 4 (added when I gave my authorization to the other side, icon grayed out, as if it were offline) Sorry again, I just realized that I wrote the final situation wrong. This is actually what I see in my Contacts view now: - myaccount@myserver:port - contact 1 (offline) - contact 2 (although I have clicked on remove!) - contact 3 - contact 4 (althuogh I have clicked on remove!) - contact 5 (offline) - contact 4 (added when the other side accepted my request) - contact 4 (added when I gave my authorization to the other side, icon grayed out, as if it were offline) - myaccount@myserver:port - contact 1 (offline) - contact 3 - contact 5 (offline) - contact 4 (added when the other side accepted my request) - contact 4 (added when I gave my authorization to the other side, icon grayed out, as if it were offline) So, "contact 4" appears three times under the first connection, twice under the second one. My team and I was playing with the shared editor, messaging etc. and it worked pretty well except that I ended up having 2056 instances of the same two contacts in my "Contacts" view. If it were not for this issue we could probably be using this tool. (In reply to comment #13) > My team and I was playing with the shared editor, messaging etc. and it worked > pretty well except that I ended up having 2056 instances of the same two > contacts in my "Contacts" view. If it were not for this issue we could probably > be using this tool. If you will detail the steps to get to having duplicate contacts instances...it will help us reproduce and we'll have a go at fixing this. For example: what server and version are you using? What arrivals/departures are necessary (to get just one duplicate to start). Can/could we reproduce with one of us? Do you see any ECF related exceptions in the log when this happens, etc? Thanks. (In reply to comment #14) > If you will detail the steps to get to having duplicate contacts instances...it > will help us reproduce and we'll have a go at fixing this. > > For example: what server and version are you using? What arrivals/departures > are necessary (to get just one duplicate to start). Can/could we reproduce with > one of us? Do you see any ECF related exceptions in the log when this happens, > etc? Thanks. Hi Scott. I'm not sure about the details. However what we observed was that the accounts producing multiple instances were logged in on several different devices at the same time. We were using Google Talk. No exceptions were logged. (In reply to comment #14) > If you will detail the steps to get to having duplicate contacts instances...it > will help us reproduce and we'll have a go at fixing this. Hi Scott, what about my previous comments? :-) (In reply to comment #16) > (In reply to comment #14) > > If you will detail the steps to get to having duplicate contacts instances...it > > will help us reproduce and we'll have a go at fixing this. > > Hi Scott, > what about my previous comments? :-) Those are helpful, but dated at this point. What's now needed is some relatively simple case, where multiple accounts show up when they shouldn't. This is complicated by the fact that multiple accounts should show up for multiple devices (known as resources in xmpp). I suspect what ultimately will be needed will be having me participate and observe (and debug) the bug using this simple use case. If either of you can isolate and describe a reproducible case, I should be able to participate at some agreed-upon time...and I suspect that that will be necessary to understand what's going on with this issue. I would like to fix this bug prior to ECF's 3.6 release...due in March 2013. Would you/Mauro and/or Torklid able to assist by answering debug questions and helping to test potential fixes? Thanks, Sorry Scott, so much time has passed since we have found this bug that we stopped using the whole thing at all, because it was not working well. Now we don't have any XMPP server installed any more, so we can't test. However I think that if you try to install a XMPP server on your LAN and start playing with a co-worker with contacts your should be able to reproduce this problem easily if nothing has changed underneath. Thanks for responding Mauro, (In reply to comment #19) > Sorry Scott, so much time has passed since we have found this bug that we > stopped using the whole thing at all, because it was not working well. > > Now we don't have any XMPP server installed any more, so we can't test. > > However I think that if you try to install a XMPP server on your LAN and > start playing with a co-worker with contacts your should be able to > reproduce this problem easily if nothing has changed underneath. We do now have an XMPP server installed for testing at osuosl.org and haven't yet been able to reproduce. Part of the problem is that this bug started out on one issue (i.e. the original bug) and I think the fix to the original problem introduced another problem, represented by comment 6 (I think). So that it's easier for me and others to understand, would you (Mauro) create a new bug that summarizes the new issue clearly...with steps to reproduce? It could also reference the discussion on this bug. Given that I've lost a lot of context over the past couple of years :), having a new bug that clarifies the secondary issue will be very helpful for me...and I think I can then fix it pretty readily. Would you be able/willing to create this new bug Mauro? It would be most appreciated, and I will guarantee a renewed effort from me to fix/address this issue once and for all. Thanks. Hi Scott, I opened but #404529 as you requested, although I'm not sure it will be any more useful for you to fix this problem (if still present) :-( I meant bug #404529. (In reply to comment #22) > I meant bug #404529. Thanks for creating the new bug. Resolving this one as fixed. |