Bugzilla – Full Text Bug Listing
| Summary: | Type check is required when cast parent of virtual node to Schema | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] Data Tools | Reporter: | Cong Chen <cong.chen> | ||||||
| Component: | Connectivity | Assignee: | song lin <linsong> | ||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | bfitzpat, hui.cao, linsong, lj | ||||||
| Version: | 1.6 | Flags: | bfitzpat:
review?
(lj) |
||||||
| Target Milestone: | 1.6RC1 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Cong Chen
Created attachment 97908 [details]
patch for 229212
Add type check in ServerExplorerVNodeContentProviderNav to retrieve the children of schema
Hi Loic, can you please have a review? Thanks! Loic, would you please review the patch? (In reply to comment #3) > Loic, would you please review the patch? > Hi Lin, Thanks for submitting the patch. Here is some of my feedback: * I would really appreciate a new patch submitted where we abstract some of that code in one common method (copied 6 times). In order to get the EMF collections, we could use the structure feature. * I would really appreciate if the variables can be slightly better named. For instance grandParent is not a name commonly used in c/s. Ancestor or something more appropriate for our domain would be great. Thanks again, ~Loic Thanks for looking at it Loic! Lin, can you address Loic's comments? Created attachment 98119 [details]
patch-for-229212
update patch according to Loic's comments.
That's definitely much cleaner. Loic, can you take another look and then we'll get this delivered. (In reply to comment #7) > That's definitely much cleaner. Loic, can you take another look and then we'll > get this delivered. > Thanks Lin, Really appreciated the follow up on this! Looks much better, please deliver. Thanks, ~Loic Please send an e-mail to the DTP-PMC mailing list requesting inclusion of this patch in the M7/RC0 release. You must get at least 2/4 PMC members to sign off on it for inclusion. Unfortunately, I'm not sure that will occur before Monday's build. (In reply to comment #9) > Please send an e-mail to the DTP-PMC mailing list requesting inclusion of this > patch in the M7/RC0 release. You must get at least 2/4 PMC members to sign off > on it for inclusion. Unfortunately, I'm not sure that will occur before > Monday's build. > Hi Brian, as I am fine with this fix not being in RC0, Lin, when RC1 reopens, please deliver the fix. Thanks, ~Loic Delivered patch to o.e.d.c.sqm.server.ui as tag v200805142345 also fixed small issue uncovered with ConnectionInfoImpl in o.e.d.c.sqm.core that occurred when the filter key was null (In reply to comment #11) > Delivered patch to o.e.d.c.sqm.server.ui as tag v200805142345 > also fixed small issue uncovered with ConnectionInfoImpl in o.e.d.c.sqm.core > that occurred when the filter key was null > Thanks Brian for delivering this. ~Loic Closing bugs |