Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 228857

Summary:

Do not use (s) in Apply Patch

Product:

[Eclipse Project] Platform

Reporter:

Dani Megert <daniel_megert>

Component:

Compare

Assignee:

Tomasz Zarna <tomasz.zarna>

Status:

VERIFIED FIXED

QA Contact:

Severity:

trivial

Priority:

Version:

3.4

Target Milestone:

3.4 M7

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
"line(s)" replaced with "lines"	none

Description Dani Megert

2008-04-25 06:55:27 EDT

HEAD of 20080425-0800.

The Apply Patch shows:
"Patch contains x added and y removed line(s)."

Using "(s)" is a UI blooper. The message should use the correct form i.e. singular or plural style. I guess in your case you could simply use plural as

"Patch contains 0 added and 0 removed lines."

sounds correct to my non-native English ear.

Please check other strings as well.

Comment 1 Tomasz Zarna

2008-04-25 07:31:10 EDT

Created attachment 97594 [details]
"line(s)" replaced with "lines"

Comment 2 Tomasz Zarna

2008-04-25 07:52:39 EDT

There is 12 more (s) in Compare/Team/CVS components. I will open a separate bug(s) ;) for them with the same justification you gave in comment 0. Thanks for pointing this out, Dani.

Comment 3 Tomasz Zarna

2008-04-25 08:31:56 EDT

Patch released but bug 228865 opened.

Comment 4 Tomasz Zarna

2008-04-30 05:15:33 EDT

Verified in I20080429-0100.