Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 228410

Summary: Error trying to approve a contact
Product: Community Reporter: Donald Smith <donald.smith>
Component: Project Management & PortalAssignee: Bjorn Freeman-Benson <bjorn.freeman-benson>
Status: CLOSED FIXED QA Contact:
Severity: blocker    
Priority: P2 CC: bjorn.freeman-benson, gabe.obrien
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Before error.
none
Error. none

Description Donald Smith CLA 2008-04-23 09:37:04 EDT 
I login to the portal.  

I try to approve a pending contact change that I have just added to the member database by clicking "approve".

I get an error in the box: Can't find organization_contacts / emo_pending_contacts with id 894!MA

I will attach screen shots.

 - Don
Comment 1 Donald Smith CLA 2008-04-23 09:38:09 EDT 
Created attachment 97224 [details]
Before error.
Comment 2 Donald Smith CLA 2008-04-23 09:38:24 EDT 
Created attachment 97225 [details]
Error.
Comment 3 Bjorn Freeman-Benson CLA 2008-04-23 10:57:32 EDT 
Coded, checked in. Waiting to go live.
Defect introduced by bug 204838
Comment 4 Karl Matthias CLA 2008-04-23 18:08:58 EDT 
Released in STAGING_201
Comment 5 Donald Smith CLA 2008-04-24 08:51:05 EDT 
Sorry, still getting the same error trying to update a pending contact change.

Will this fix work for all new contact changes, or should it work on those that are still pending?  In other words, is this just a case where we need to manually approve the one already in the DB?

 - Don
Comment 6 Donald Smith CLA 2008-04-24 10:01:11 EDT 
Sorry - just realized this is still in stanging and not pushed yet.

 - Don
Comment 7 Bjorn Freeman-Benson CLA 2008-04-24 10:53:55 EDT 
(In reply to comment #6)
No, you're just confused by our terminology. STAGING_nnn is our source code control tag - if we say say "released in STAGING_nnn" it means that that tag (misnamed STAGING_nnn) has been release to production. So it should have fixed the problem. We're looking into it.
Comment 8 Bjorn Freeman-Benson CLA 2008-04-24 11:28:58 EDT 
Coded (fixed, again) and checked-in. Waiting for release to production.
Sorry Donald.
Comment 9 Karl Matthias CLA 2008-04-25 20:09:11 EDT 
Released in STAGING_205 where code was required to be released.  Closed otherwise.  Please see final comments and resolution for actual bug status.
Comment 10 Donald Smith CLA 2008-04-30 07:52:52 EDT 
Sorry, still does not work.  When I click "+1 approve" then "save" I get this error:

SQL Trouble: Unknown column 'Oranizations.OrganizationID' in 'where clause'


 - Don
Comment 11 Bjorn Freeman-Benson CLA 2008-04-30 10:01:47 EDT 
We're certainly learning some embarrassing limitations of our testing framework here :-(
Coded, tested (again), and checked in. Will go live soon.

Cause: the testing framework does not use the object factory with "create one object" function. The code worked correctly for id = null, but not if id != null. But the testing framework does not test the id != null case for any of our factories. That's not good.
Comment 12 Gabe O'Brien CLA 2008-04-30 12:35:19 EDT 
Bjorn,

Shouldn't a bug be opened about this limitation of the test framework so we can track and fix it?

gO'
Comment 13 Karl Matthias CLA 2008-04-30 12:59:56 EDT 
Released in STAGING_209.  See actual comments and bug resolution for real status of this bug.  This message does not construe any meaning not already mentioned.