Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 227633

Summary:	[update] Support pack200 archives on update sites
Product:	[Eclipse Project] Equinox	Reporter:	Simon Kaegi <simon_kaegi>
Component:	p2	Assignee:	P2 Inbox <equinox.p2-inbox>
Status:	RESOLVED DUPLICATE	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	jed.anderson, jeffmcaffer, pascal, wong
Version:	3.4	Keywords:	helpwanted
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Simon Kaegi

2008-04-17 15:40:45 EDT

We should look at using the packed bundles when creating the metadata and create appropriate pack200 artifact descriptors.

Comment 1 John Arthorne

2008-04-19 23:05:53 EDT

I thought Pascal already implemented this...

Comment 2 Jeff McAffer

2008-05-04 07:53:38 EDT

me too.  I remember seeing code in the generator for "use existing pack200 archives" or some such

Comment 3 Pascal Rapicault

2008-05-05 20:50:48 EDT

The support for pack200 you are thinking about is enabled when running the metadata generator on an existing update site, not when generating metadata on the fly.

Comment 4 Jeff McAffer

2008-05-05 21:02:06 EDT

right and this bug is actually about automatically adding ArtifactDescriptors for pack.gz artifacts in the local repository used to represent a remote update site IF the site has the pack flag set to true.  Doing that seems quite straight forward but there are issues around the download failure mode.  What if we say there is a pack.gz artifact in repo R and some client goes for it but it really is not there.  What does the client do then?>  Try another artifact descriptor from R or move onto repo S?  What if there is no other repo?  To the user it would look like the artifact is not available when really it is.

in the p2 call today we discussed this and no one could say conclusively what would happen so this bug was interesting for its collateral effect of ensuring that the failure path (which can happen regardless of the function proposed here) works in a reasonable way.

I'll add Ben to this but no guarantees...

Comment 5 Pascal Rapicault

2008-05-05 21:50:40 EDT

Failing to find the packed file will cause the canonical artifact to be downloaded. This is handled in the mirror request and has been fixed in M7.

Note that I don't think there is much value in spending time on this bug as I don't think that many sites are pack'ed.

Comment 6 Jeff McAffer

2008-05-05 22:38:31 EDT

ok.  my main interest was in the failure case so if that is handled, we can defer this.

Comment 7 Pascal Rapicault

2009-04-09 13:36:01 EDT

This has been fixed accidentally in 236762

*** This bug has been marked as a duplicate of bug 236762 ***