Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 227030

Summary: Project info bugzilla_url() fails when Bugzilla url in Meta Data
Product: Community Reporter: Eclipse Webmaster <webmaster>
Component: WebsiteAssignee: phoenix.ui <phoenix.ui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
project-info.class.php patch none

Description Eclipse Webmaster CLA 2008-04-14 16:57:56 EDT
Created attachment 96001 [details]
project-info.class.php patch

After receiving a report about a broken 'Bugs' link on the leftnav of the Eclipselink project I forwarded it to the Eclipselink team.  They responded that this issue had been present for a while and they attributed it to the presence of () in their Meta Data.

I began digging into their website and then into the project support code to try and find at what point the issue was occurring.  While examining the project-info.class.php source I noticed that the bugzilla_url function was not returning correctly as it was generating 'PHP Notice:  Trying to get property of non-object in /projects/common/project-info.class.php on line 72' in the logs.  After talking to Nathan about the ProjectInfo spec(http://wiki.eclipse.org/ProjectInfoKeys) he and I concluded that the function was not correctly handling multiple Meta Data entries for the Bugzilla key.  Noticing that the newsgroup code did correctly handle multiple entries I adapted it to the Bugzilla function and confirmed that on my test setup it now correctly returns the Bugzilla URL if specified, or if the URL is not present and the ProductID is it will return that in a crafted URL.

I've attached a patch for review and application.

-M.
Comment 1 Denis Roy CLA 2009-03-19 15:15:08 EDT
Matt,

I hope 11 months later,  +1
Comment 2 Eclipse Webmaster CLA 2009-04-01 15:46:30 EDT
Ok, I've retested the patch and applied it.

-M.