Bugzilla – Full Text Bug Listing
| Summary: | [KeyBindings] regex content assist tooltip has wrong key format for Mac OSX | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Sanjay Patel <sanjay3000> | ||||
| Component: | UI | Assignee: | Markus Keller <markus.kell.r> | ||||
| Status: | VERIFIED FIXED | QA Contact: | Paul Webster <pwebster> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | markus.kell.r | ||||
| Version: | 3.4 | ||||||
| Target Milestone: | 3.6 M7 | ||||||
| Hardware: | PC | ||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | 274690 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
Kim, I'll pass this to you, re-direct if necessary. The custom space character is debatable.
If you go to 'System Preferences > Keyboard & Mouse > Keyboard Shortcuts'
and add a shortcut for 'About Finder' with keys Command+Shift+Space, then the table renders the space as 'Space' but the menu in the Finder renders it with the ugly underscore.
The Apple Human Interface Guidelines also use 'Space' in their shortcuts lists, and even iTunes overrides the default rendering: 'Controls > Play/Pause' uses 'space'.
Since the ugly underscore only causes confusion, we should just use the default rendering from AbstractKeyFormatter.properties ('Space').
I tried to fix this, but the fix didn't work on Cocoa, probably due to bug 274690. Created attachment 134110 [details] Fix attempt (needs bug 274690) Should we look at getting this into RC1? PW > Should we look at getting this into RC1? No, unless bug 274690 gets fixed and my patch turns out to work fine then. We've had the current rendering style since the beginning, and it's not fundamentally wrong. I was hoping for a quick fix, but since it didn't work, I wouldn't invest too much for 3.5. Fixed in HEAD. Verified in I20100429-1549 Cocoa and Carbon. |
Build ID: M20071023-1652 Steps To Reproduce: 1. Go to "Edit" menu and then open the "Find/Replace" dialog. 2. Select the "Regular expressions" checkbox. 3. After the Content Assistance light-bulb icon appears to the left of the text input widget, hover over it. 4. A tooltip appears that says: "Content Assist Available (^.)" The key combination is wrong - it should be "Ctrl-Space" as shown on Windows and Linux. A little debugging shows that org.eclipse.jface.bindings.keys.formatting.NativeKeyFormatter has a special case for Carbon: public final String format(final int key) { final IKeyLookup lookup = KeyLookupFactory.getDefault(); final String name = lookup.formalNameLookup(key); // TODO consider platform-specific resource bundles if ("carbon".equals(SWT.getPlatform())) { //$NON-NLS-1$ String formattedName = (String) CARBON_KEY_LOOK_UP.get(name); if (formattedName != null) { return formattedName; } } return super.format(key); } The CARBON_KEY_LOOKUP is returning the bogus string. More information: