Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 225759

Summary: Incorrect sizes in install dialog
Product: [Eclipse Project] Equinox Reporter: Alexander Gurov <a.gurov>
Component: p2Assignee: Matthew Piggott <matthew>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: pascal, susan
Version: 3.4   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 232223, 240055    
Attachments:
Description Flags
Feature size is zero (feature manifest contains value "20") none

Description Alexander Gurov CLA 2008-04-04 11:11:05 EDT 
Feature size is always shown as "0".
Comment 1 Alexander Gurov CLA 2008-04-04 11:12:17 EDT 
Created attachment 94863 [details]
Feature size is zero (feature manifest contains value "20")
Comment 2 Pascal Rapicault CLA 2008-04-15 07:57:27 EDT 
Did you continue with the installation? Was it successful?
Which build were you using?
Comment 3 Alexander Gurov CLA 2008-04-15 08:16:23 EDT 
Tested builds:

Version: 3.4.0
Build id: I20080330-1350

Version: 3.4.0
Build id: I20080409-1425

Nevertheless installation was successful.
Comment 4 Alexander Gurov CLA 2008-04-15 08:34:50 EDT 
In

Version: 3.4.0
Build id: I20080410-1022

the problem also exists.
Comment 5 Pascal Rapicault CLA 2008-04-30 21:46:41 EDT 
Could you indicate the site you are installing from? Thx.
Comment 6 Alexander Gurov CLA 2008-05-06 03:32:00 EDT 
You can check Ganymede builds with Subversive update site:

http://download.eclipse.org/technology/subversive/0.7/update-site/

Also I checked M7 and found that now update manager always shows "Unknown" instead of "0".
Comment 7 Pascal Rapicault CLA 2008-05-06 14:17:29 EDT 
This is because the artifact descriptors generated do not have any size info. 
This will require changes in the feature.xml parser we have since we don't extract the information.
Comment 8 Pascal Rapicault CLA 2008-05-12 15:53:11 EDT 
Given that very few people ever specified their size and that the changes are pretty invasive, we will not be fixing this in 3.4. 
To improve the experience of your users, you may want to consider generating p2 metadata, see http://wiki.eclipse.org/Equinox_p2_Metadata_Generator.
Comment 9 Susan McCourt CLA 2008-07-08 14:55:54 EDT 
I opened bug #240055 to revisit the presentation of size given it takes so long to compute the size, and given that few people are specifying it.  

Does this bug represent the effort to extract the feature size info as specified in the update site and move it to an artifact descriptor?  

Or a more general question...are we going to change the way size is computed for 3.5 or will it be fast enough to be worth showing in the UI?
Comment 10 Pascal Rapicault CLA 2009-02-04 10:55:40 EST 
For appropriate size computation to happen we need to have p2 metadata.
Comment 11 Susan McCourt CLA 2009-02-04 13:19:20 EST 
(In reply to comment #10)
> For appropriate size computation to happen we need to have p2 metadata.
> 
Just to be clear - you are saying that we will not attempt to map the sizes specified in feature.xml to p2 metadata in the update site publisher?
Comment 12 Pascal Rapicault CLA 2009-02-05 06:28:34 EST 
When connected to a remote update site we will not carry over the size information which most of the time is 0 anyway. When the update site is local, then we will generate proper size.