Bugzilla – Full Text Bug Listing
| Summary: | [WorkingSets] WorkingSetsDialog seems to be damaged | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Krzysztof Daniel <krzysztof.daniel> | ||||||||
| Component: | Team | Assignee: | Platform Team Inbox <platform-team-inbox> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||
| Severity: | minor | ||||||||||
| Priority: | P3 | CC: | blazej.kroll, eclipse, emoffatt, krzysztof.daniel, tomasz.zarna | ||||||||
| Version: | 3.4 | ||||||||||
| Target Milestone: | 3.4 M7 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows Vista | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
Kim, if this is a Vista bug send it back to me... I'm not even sure what dialog this is. Could you refine your steps to reproduce please? (or if it's easier a patch would also do ;) Sorry for the trouble Kim. The name of the dialog is org.eclipse.team.internal.ui.wizards.WorkingSetsDialog which extends TitleAreaDialog. I hope I will manage to prepare fix tomorrow. Steps to reproduce are to try to checkout a couple of project into the working set (on the last page of 'Check out as' wizard select 'Add project to a working set', then browse. I have look into the code. First you have: Composite composite = (Composite) super.createDialogArea(parent); ... ... then layout = new GridLayout(); ... ... composite.setLayout(layout); So WSD changes the layout introduced by the TitleAreaDialog. Resolution seems quite simple: replace layout = new GridLayout(); with layout = (GridLayout) composite.getLayout(); I will check out that project and test it tomorrow. Created attachment 94742 [details]
Updated WorkingSetsDialog's Layout
Created attachment 94743 [details]
corrected layout patch
Changed the layout of Working Sets Dialog as included in the screenshot.
Reassigning. Released to HEAD, thanks guys. PS. Please take a look at bug 225749 I've just opened. I added you to CC already ;) Looks fine in I20080429-0100, but please don't forget about bug 225749. |
Created attachment 94334 [details] Damaged dialog Build ID: I20080330-1350 Steps To Reproduce: 1. Download M6 2. Try to import Platform-UI into the working set 3. A damaged dialog appears (as attached, invalid separator marked). More information: Or at least I believe it is damaged. The separator should be on the border between white and grey area, and should fill the whole dialog width. You can assign this to me, I hope I will be able to fix this in M7.