Bugzilla – Full Text Bug Listing
| Summary: | Add Ganymede Update Site | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Ian Bull <irbull> | ||||||||
| Component: | Releng | Assignee: | Kim Moir <kim.moir> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | aniefer, contact, david_williams, dj.houghton, john.arthorne, kim.moir, litrik, nboldt, pascal, samuelwu, simon_kaegi, susan | ||||||||
| Version: | 3.4 | Flags: | john.arthorne:
review+
dj.houghton: review+ pascal: review+ |
||||||||
| Target Milestone: | 3.4 RC3 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows XP | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Ian Bull
The slowness here is because we are generating all the p2 metadata for the site when it is added. This involves downloading features, parsing, etc. The plan is for the Ganymede site to have the p2 metadata added to it, so users will not have any delay (bug 208648). Cool, thanks John. Regrading the slowness, I would imagine a progress bar should be added instead of doing all the parsing, D/L, etc... in the UI thread. Although I guess this is only an issue for Update Sites that don't have the P2 meta-data. Is there a plan to have the update site included with the Eclipse build by M6? Or will users have to add this manually? >Regrading the slowness, I would imagine a progress bar should be added instead >of doing all the parsing, D/L, etc... in the UI thread. Although I guess this >is only an issue for Update Sites that don't have the P2 meta-data. Ian, the intention is that when a repo is added, there is minimal access to the repo, only validation of the URL as a known site. The reading should occur in a background job which eventually refreshes the available features tab. That's why the "add" code is running in the UI thread. There's discussion of this in bug #204184. But the reality (today, and likely for M6) is that there is more happening during the validate sequence than we would hope. John, do we know for sure that there is really downloading and parsing happening in the add (vs. the load?) Simon? >But the reality (today, and likely for M6) is that there is more happening >during the validate sequence than we would hope. John, do we know for sure >that there is really downloading and parsing happening in the add (vs. the >load?) Simon? Never mind, it just occurred to me that I know why this is happening. The add of the repo is refreshing the available IU view, and the way the input element for the category view is structured is subverting the deferred/background refresh. Suffice to say this will be fixed early in M7. This is probably more detail than you care to know, but I realized just now that the validate isn't the problem in this case, there is a load being forced that shouldn't be. The UI bug for this part of the problem is bug #222563, but I don't want to close this as a duplicate because there may be some tuning needed on the core side, too. Note that we currently download all the features from the Ganymede update site because there is a bad digest.zip (bug 221993) but that will be fixed for M6. And to answer the original question and subject of the bug: we likely won't be able to add the Ganymede update site automatically in M6. Until we know for sure that the update site will have the p2 metadata, it will just cause too much delay (a five minute freeze when opening the install dialog). Susan, Thanks for all the details :-). I will keep an eye out for new I-Builds early in the M7 cycle. (In reply to comment #6) > And to answer the original question and subject of the bug: we likely won't be > able to add the Ganymede update site automatically in M6. Until we know for > sure that the update site will have the p2 metadata, it will just cause too > much delay (a five minute freeze when opening the install dialog). > John, this makes sense to me. I assume that Ganymede will have this fixed by the +2 or +3 date, but until then I agree, we can't have the UI freeze for 5 minutes. Does Bjorn (or whoever maintains the Ganymede update site) know that the site won't be included with the Eclipse SDK until the p2 metadata is added? I haven't attended the conference calls, so maybe everyone knows the site won't be listed again until M7, but if not, I think some will view the missing site as a regression. This will happen once the fix for bug 228046 is released This also relates to bug 216675 Verified Ganymede site is there in I20080415-1646. The build id from yesterday's build was wrong. This was tested in the I20080427-2000 build. Unfortunately this briefly worked because we were doing too much parsing of features on startup, but with that fixed we no longer discover the ganymede site. *** Bug 230807 has been marked as a duplicate of this bug. *** Created attachment 101387 [details]
Work in progress to introduce an add repository action
I'm not sure if we will go with this approach for 3.4, but wanted to attach the work so far in case it can be used later.
Created attachment 101619 [details]
Settings zip file
This zip file contains a pre-populated configuration preference store with the ganymede and Eclipse project sites.
After much discussion we decided the simplest way to add the Ganymede and Eclipse project update sites for 3.4 is to pre-populate the configuration preference store during the build. Attached is a preference store that can be added at build-time to ensure these repositories are added. Andrew will look into adding these in the build. I tested by grabbing the latest SDK build, unzipping, and then unzipping the above preference files into the configuration directory. When the Software Updates dialog is opened, the repositories are listed in the Available Software tab. Created attachment 101633 [details]
patch to platform-feature
Kim I think that this patch should be sufficient to add the prefs to the builds.
The platform feature is already contributing everything in its rootfiles directory. As well, the master-root feature is picking everything up from org.eclipse.platform/rootfiles.
Similarily, the platform & sdk packaging.properties files pick up the entire configuration directory.
Of course this deserves a test build I think.
Marking RC3, I'm not sure there is enough time before RC2 Running a test build now *** Bug 234051 has been marked as a duplicate of this bug. *** Confirmed fix in test build. John, Pascal, DJ please +1 this bug for RC3. released for I20080528-2000. Verified in 3.4 RC3 (I20080530-1730). Thanks everyone! |