Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 223806

Summary:	[navigation] Go to Line dialog should remember the last entered value
Product:	[Eclipse Project] Platform	Reporter:	Stepan Herold <sherold.dev>
Component:	Text	Assignee:	Platform-Text-Inbox <platform-text-inbox>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	daniel_megert, markus.kell.r
Version:	3.3
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Stepan Herold

2008-03-25 07:01:54 EDT

Build ID: I20070625-1500

Steps To Reproduce:
1. invoke the 'go to line' dialog
2. enter some line number and press enter
3. invoke the dialog again


More information:
This is an usability issue. It would be nice if the dialog remembered the last entered value.

It happens quite often that you use the 'go to line' dialog, then you move a few lines up or down and than you want to move quickly back to the original line. Currently, you have to remember the orignal line number and enter it again.

When the dialog is invoked the last entered value should be selected so that a new value can be entered inmediatly, w/o having to delete the old one.

Comment 1 Markus Keller

2008-06-09 09:57:51 EDT

I rather think the dialog should be pre-filled with the current line number, see bug 236241. To get a history, the text field could be converted into a combo.

Comment 2 Dani Megert

2008-06-09 10:21:32 EDT

I disagree with comment 1. Especially adding a history with line numbers sounds overkill.

Comment 3 Stepan Herold

2008-07-11 11:36:35 EDT

I don't think that prefilling the text field with the current line would make much sense. There is no point in using the dialog for bringing you to the line where you already are. You should think about the use cases the dialog was intended for in the first place.

snippet from bug 236241:

>Advantages:
>- Allows to copy the line number
>- Allows to modify the line number (e.g. when you mistyped 17493 as 17439)

Advanatage #1:

This seems to me like a hack. The dialog was designed to take you to a desired line and not as an aid for copying the current line number. BTW, most of the developers I know have the editor's feature 'show line numbers' always on and writing down the line number manually takes you less than a second.

Advanatage #2:

This should work even better with the fix suggested in this bug, because you would always get the last mistyped value even if you changed the line between the two dialog invocations.

Comment 4 Dani Megert

2010-05-17 10:51:48 EDT

Due to accessibility benefit we'll initialize the dialog as suggested by Markus. In addition, I don't want to remember the last line number per file.