Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 223581

Summary: [ui] prompted to Restart when downloading multiple features
Product: [Eclipse Project] Equinox Reporter: Chris Aniszczyk <caniszczyk>
Component: p2Assignee: Susan McCourt <susan>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: pascal, susan
Version: 3.4   
Target Milestone: 3.4 M7   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Chris Aniszczyk CLA 2008-03-23 13:28:15 EDT 
Here's an example workflow:

1) download fresh SDK
2) download Mylyn
3) download Releng Tools while Mylyn is downloading

Notice that you get prompted to restart after Mylyn is finished... Releng tools hasn't even started at this point to download... would it make sense to only prompt after everything is completed that's currently in queue?

Or is this the intended design?
Comment 1 Pascal Rapicault CLA 2008-03-23 18:32:40 EDT 
In fact it should not have been possible to start the installation of the releng tools until the mylyn install had completed.
Comment 2 Susan McCourt CLA 2008-03-25 13:15:35 EDT 
It was not a particular design so much as an artifact of the implementation.  We prompt for restart whenever we receive an event that the running p2 profile has been modified.  So in this case, once the install for Mylyn actually updates the profile, we prompt for restart.  The UI currently does not remember what has been queued up, though we could probably do this easily with job families and such.  Marking M7.  I'm going to look at our job structure in terms of progress reporting during this time, also.
Comment 3 Susan McCourt CLA 2008-03-26 19:11:03 EDT 
Another thing that needs to be done here is that if a restart is in progress, another one should not be initiated, and we probably should cancel any running jobs.
Comment 4 Susan McCourt CLA 2008-04-17 00:51:55 EDT 
Fixed in HEAD >20080416.

The ProvisioningOperationRunner now accumulates requests for restarts and only performs a restart when the last scheduled operation completes.

But perhaps more importantly, per bug #227042, provisioning actions that modify a profile are now disabled when there is a scheduled operation against the same profile.