Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 223579

Summary:	Apply patch: ignore path doesn't work with absolute paths on Windows
Product:	[Eclipse Project] Platform	Reporter:	Dave Syer <david_syer>
Component:	Compare	Assignee:	Platform-Compare-Inbox <platform-compare-inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P5	Keywords:	helpwanted
Version:	3.4
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:	stalebug

Description Dave Syer

2008-03-23 12:17:55 EDT

Build ID: Build id: I20080207-1530

Steps To Reproduce:
1. Apply a patch created on a Windows machine with absolute paths (e.g. starting D:\...\).
2. Choose Patch options
3. Select "Ignore leading path name segments" with any value
4. The paths elements *after* the drive letter are ignored, but the drive letter is still included, leading to (invalid) file names with colons


More information:

Comment 1 Tomasz Zarna

2008-03-25 05:00:48 EDT

Was the patch created with Eclipse? It's possible that certain changes in the patch format can cause the Apply Patch Wizard not to work as expected. Might it be the reason?

Comment 2 Dave Syer

2008-03-25 09:03:31 EDT

AS far as I know the patch was created with Eclipse (but it wasn't created by me so I'm not 100% sure).  You seem to be saying that Eclipse might not be able to apply its own patches.  Does that make sense?  I don't follow the bit about "certain changes".

Comment 3 Tomasz Zarna

2008-03-25 09:55:59 EDT

Sorry, by "certain changes" I meant a patch generated outside Eclipse with slightly different format... Or a patch edited manually... I certainly didn't mean that Eclipse might not be able to apply its own patches, that would definitely a bug :) Sorry for the confusion again.

Comment 4 Dave Syer

2008-04-13 05:57:15 EDT

Actually, it looks like the patch is applied successfully - it is just confusing that Eclipse adds the "D:" at the beginning of the file name.  Does that make sense?

Comment 5 Tomasz Zarna

2008-04-14 05:53:42 EDT

Frankly speaking, I've never seen a patch with an absolute path. Are you sure it was created with Eclipse? AFAIK, available patch roots are: workspace, project and selection. I think it's rather non-standard configuration, so I won't make it one of our priorities. Patches are welcome, though :)

Comment 6 Eclipse Webmaster

2019-09-06 16:15:24 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

Comment 7 Eclipse Genie

2022-01-02 07:35:38 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.