Bugzilla – Full Text Bug Listing
| Summary: | Process's UUID is returned null | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Raheel Ashraf <rashraf> | ||||||||
| Component: | TPTP | Assignee: | Bing Xu <xubing> | ||||||||
| Status: | CLOSED WONTFIX | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | analexee, igor.alelekov, jgwest, jkubasta, paulslau, xubing | ||||||||
| Version: | unspecified | Flags: | xubing:
review?
|
||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows XP | ||||||||||
| Whiteboard: | housecleaned460 closed460 | ||||||||||
| Bug Depends on: | 228379 | ||||||||||
| Bug Blocks: | 219395 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Raheel Ashraf
I took a look while Raheel and I were examining the problem, and the _UUID variable of the ProcessImpl class is never set to anything but NULL. Thus, when getUUID is called, a NULL value will always be returned. The UUID is reported to the client after the startProcess XML command is sent to the AC. The following is the XML response to that command that is received by the client: <processStarted iid="org.eclipse.tptp.processController"> <processID>%lu</processID> <processUUID>%s</processUUID> <envVarCount>%d</envVarCount><envVarList> *Environment Labels encoded in Base64* </envVarList> </processStarted> The execution framework should be able to read the UUID when it receives this XML command from the agent controller. A quick scan looks like the above XML is processed by "private void processStarted(Hashtable commandHash)" of "ProcessCommandHandler" inside ProcessImpl.java (under org\eclipse\tptp\platform\execution\client\core\internal) Bing, can have a look? Created attachment 93497 [details]
patch to set process UUID properly.
Jonathan, can you reivew the patch. Thanks. Raheel, would you please test the patch? Thanks. Patch works for me Created attachment 95929 [details]
Move main query method from AgentController.java to ProcessImpl.java.
Jonathan, can you review the patch.
Created attachment 96065 [details]
Make query method private instead of public
Jonathan, can you review it. Thanks.
Patch is good. Patch committed to Head Hi Bing, The patch caused regression #227618 I would recommend to roll back the patch to resolve blocker #227618. The current bug should be fixed in BaseAgentImpl/ACCollector module. Bing's solution is Ok but some fixes on agents site are required. I've commented out value assignment to _UUID in ProcessImpl. It is temporary solution until TI agent will be able to provide correct UUID. (see Bug 139984 and Bug 130597) forget to mention :), caused Bug 227618 Does this change fix the regression or is a fix for 130597 (currently targeted to "future") needed in 4.5 i7? (In reply to comment #13) > Does this change fix the regression or is a fix for 130597 (currently targeted > to "future") needed in 4.5 i7? > My changes only fix regression. To put fix for 223385 back only partial implementation of bug 130597 required, functionality for obtaining process UUID. I hope it will not require to much changes in sources, if it isn't so we have to roll back this fix completely. More details I am going to provide in Monday. Hi Alex, The patch isn't too complicate. So do you want me to roll back completely or just port of the patch? Bing, to minimize changes during TP leave commit as is (with commented return), required function in AC baseAgent will be provided in I8. Alex, any update on this? (In reply to comment #17) > Alex, any update on this? > Depends on bug 228379 is in questionable section for 4.5. It will be considered accordingly to the queue. As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this defect is resolved as WONTFIX by the Project Lead since the originator of this defect has an inactive Bugzilla account and it may be no longer relevant. If this defect is still relevant and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since the originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. |