Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 222386

Summary:	[regression] Properties of connection or subsystem are no longer available due to unhandled Event loop exception in user actions
Product:	[Tools] Target Management	Reporter:	Martin Oberhuber <mober.at+eclipse>
Component:	RSE	Assignee:	Xuan Chen <xuanchen>
Status:	CLOSED FIXED	QA Contact:	Martin Oberhuber <mober.at+eclipse>
Severity:	critical
Priority:	P1
Version:	3.0
Target Milestone:	3.0 M6
Hardware:	PC
OS:	Windows XP
Whiteboard:
Bug Depends on:	187395
Bug Blocks:

Description Martin Oberhuber

2008-03-12 07:14:49 EDT

Create an SSH Only connection.
Select "Sftp Files" and right-click. 
There is no "Properties" item in the menu.

This is quite apparently a regression due to the checkin for bug 187395, since the error log shows this traceback:

java.lang.NullPointerException
	at org.eclipse.rse.internal.useractions.ui.SystemDynamicCompileMenu.getContributionItems(SystemDynamicCompileMenu.java:71)
	at org.eclipse.ui.actions.CompoundContributionItem.getContributionItemsToFill(CompoundContributionItem.java:101)
	at org.eclipse.ui.actions.CompoundContributionItem.fill(CompoundContributionItem.java:70)
	at org.eclipse.jface.action.MenuManager.update(MenuManager.java:666)
	at org.eclipse.jface.action.MenuManager.update(MenuManager.java:585)
	at org.eclipse.jface.action.MenuManager.fill(MenuManager.java:236)
	at org.eclipse.jface.action.MenuManager.update(MenuManager.java:666)
	at org.eclipse.jface.action.MenuManager.handleAboutToShow(MenuManager.java:396)
	at org.eclipse.jface.action.MenuManager.access$1(MenuManager.java:391)
	at org.eclipse.jface.action.MenuManager$2.menuShown(MenuManager.java:417)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:234)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
[...]


-----------Enter bugs above this line-----------
TM 3.0M5
installation : eclipse-SDK-3.4M5 (I20080207-1530), cdt-4.0.0M5, emf-2.4.0M5
     DSF-N20071113, ECF-2.0m5, PHPEclipse-1.2.0.20080208, Releng.Tools-3.4M5,
     Subversive-0.7.0.v20080214, SWT-MemMonitor, WR-Retriever-3.0.v20070604,
     Mylyn-2.3.0.I20080214-1500, RXTX-2.1-7r3b, J9Launching
RSE install  : RSE-SDK-I20080215-1245, TM-terminal, TM-discovery
java.runtime : Sun 1.6.0_02-b06 -Xmx512m -XX:MaxPermSize=128m
os.name:     : Windows XP 5.1, Service Pack 2
------------------------------------------------
systemtype   : Windows-local, Dstore-win, Dstore-linux
targetos     : Red Hat Enterprise Linux WS release 4 (Nahant Update 3)
targetuname  : Linux parser 2.6.9-34.EL #1 i686 athlon i386 GNU/Linux
targetvm     : Sun Java HotSpot(TM) Client VM (build 1.4.2_12-b03, mixed mode)
------------------------------------------------

Comment 1 Martin Oberhuber

2008-03-12 07:15:35 EDT

Critical since essential functionality is missing. To be fixed for M6.
Only workaround for now is to not install the useractions plugin.

Comment 2 Xuan Chen

2008-03-12 11:17:20 EDT

I will remove the dynmanic submenu definition from the useractions plugin.  It really is the subsystem which wants compile command and user action to define those menus.

I will also add the check for IRemote file inside getContributionItems() method.

Comment 3 Xuan Chen

2008-03-12 15:48:53 EDT

I've committed the fix to cvs.

Basically, I removed the dynamic menu from the user actions plugin. And also added checking in the ContributeItem code.

Comment 4 Martin Oberhuber

2008-03-13 06:39:23 EDT

Verified, thanks