Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 222090

Summary:	CVS property page text fields should be copyable
Product:	[Eclipse Project] Platform	Reporter:	Chris Aniszczyk <caniszczyk>
Component:	CVS	Assignee:	Dani Megert <daniel_megert>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	contact, daniel_megert, markus.kell.r, tomasz.zarna
Version:	3.4
Target Milestone:	4.3 M3
Hardware:	All
OS:	All
Whiteboard:

Description Chris Aniszczyk

2008-03-10 13:57:56 EDT

Currently, the fields repo root, repo path and repo tag aren't editable... which is fine... however, they should still be copyable... sometimes its useful to copy/paste that text from that preference page.

Comment 1 Benjamin Cabé

2008-03-10 16:56:23 EDT

Same issue with CVSFilePropertiesPage. I'm on it :op

Comment 2 Chris Aniszczyk

2008-03-10 16:59:35 EDT

omg omg, wait Ben, I want to use this bug for my 'Contributing to Eclipse' webinar... how about you fix CVSFilePropertiesPage and leave me CVSFolderPropertiesPage :)?

Comment 3 Benjamin Cabé

2008-03-10 17:02:26 EDT

Oh :) No problem, I leave it all to ya!

Comment 4 Chris Aniszczyk

2008-03-10 17:05:58 EDT

Thank you sir! :)

Comment 5 Tomasz Zarna

2008-03-11 05:29:01 EDT

Good luck guys. Should I prepare a special reward for the one who first finishes his part? :)

Comment 6 Tomasz Zarna

2008-03-26 06:45:48 EDT

*** Bug 224069 has been marked as a duplicate of this bug. ***

Comment 7 Markus Keller

2009-05-26 13:42:33 EDT

*** Bug 201871 has been marked as a duplicate of this bug. ***

Comment 8 Markus Keller

2009-05-27 04:53:23 EDT

(In reply to comment #2)
> omg omg, wait Ben, I want to use this bug for my 'Contributing to Eclipse'
> webinar...

Chris, do you still need this bug open, or can it eventually be fixed? ;-)

Comment 9 Dani Megert

2012-10-03 05:41:16 EDT

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=99d1066284f94d75c0f6566b198ad86cc72b47cc

Comment 10 Markus Keller

2012-10-03 09:19:46 EDT

In CVSPropertiesPage#createReadOnlyText(..), you should call
    text.setBackground(getDisplay().getSystemColor(SWT.COLOR_WIDGET_BACKGROUND));
, otherwise it looks bad on Mac and Linux, see bug 71765 comment 17.

Comment 11 Dani Megert

2012-10-03 09:36:33 EDT

(In reply to comment #10)
> In CVSPropertiesPage#createReadOnlyText(..), you should call
>    
> text.setBackground(getDisplay().getSystemColor(SWT.COLOR_WIDGET_BACKGROUND));
> , otherwise it looks bad on Mac and Linux, see bug 71765 comment 17.

Thanks, good catch!

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=213dad1ac17e243e5f6729cab7d87392154c9193

Comment 12 Dani Megert

2012-10-31 05:02:18 EDT

Verified in 4.3-I20121030-2000.