Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 22042

Summary:	[GlobalActions] Find/Replace GlobalAction is not LabelRetargetAction
Product:	[Eclipse Project] Platform	Reporter:	Randy Hudson <hudsonr>
Component:	UI	Assignee:	Platform UI Triaged <platform-ui-triaged>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	trivial
Priority:	P5	CC:	n.a.edgar, unknown63
Version:	2.0	Keywords:	helpwanted
Target Milestone:	---
Hardware:	PC
OS:	Windows 2000
Whiteboard:	stalebug

Description Randy Hudson

2002-07-30 11:22:31 EDT

I would like to re-label the FindReplace action with my own label.  When I 
register my Global aciton handler for find/replace, workbench ignores my label 
for that action.  Why can I change the label for Undo, but not for Find?  
Suppose I don't wish to implement replace, and just find?

In general, if you are going to reserve an accelerator like Control+F, and a 
menu slot, give me the flexibility to relabel the action.  Of course, unless I 
am an idiot, I will still label the Action "Find " + some other text.  But 
trust me to do the right thing.

Comment 1 Nick Edgar

2002-07-30 15:59:45 EDT

To change this to be a LabelRetargetAction at this stage risks breaking the 
label if the handling action does not have its text properly set.
However, the text editor's handler looks OK.

Kai, do you see any problem with doing this?

Comment 2 Tom Hofmann

2003-09-16 10:14:57 EDT

It's been a while... but still no problem for platform-text to do what you want.
Moving back.

Comment 3 Nick Edgar

2005-04-28 14:00:29 EDT

Not for 3.1.

Comment 4 Randy Hudson

2005-04-28 15:25:43 EDT

If an editor only supports find and not replace (for example, a non text-based 
editor), then it would be nice to just call the action "Find".

Comment 5 Paul Webster

2007-04-05 19:01:44 EDT

Assigning to component owner
PW

Comment 6 Randy Hudson

2007-06-20 21:23:41 EDT

The only thing to do here is change the superclass, and look for handlers with poorly set strings. There only thing that can be checked for (null) is already being checked.

Comment 7 Eclipse Webmaster

2019-09-06 15:32:34 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

Comment 8 Eclipse Genie

2022-01-23 17:12:23 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.