Bugzilla – Full Text Bug Listing
| Summary: | XML Validator Preference Settings doesn't respond. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP Source Editing | Reporter: | David Carver <d_a_carver> | ||||
| Component: | wst.xml | Assignee: | Gary Karasiuk <karasiuk> | ||||
| Status: | CLOSED FIXED | QA Contact: | Nitin Dahyabhai <thatnitind> | ||||
| Severity: | major | ||||||
| Priority: | P3 | CC: | valentinbaciu | ||||
| Version: | 3.0 | Flags: | thatnitind:
review?
(karasiuk) |
||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
David Carver
Any updates on this issues, I'm still getting this with the latest I Builds for 3.0. I've tried this on both Windows and Linux and I can't reproduce this. I used driver http://build.eclipse.org/webtools/committers/wtp-R3.0-I/20080314073909/I-I20080314073909-20080314073909/ If you have any more details on how to reproduce this, please post them. I'd also be interested to know if you can reproduce this on another JVM. Gary, I'll see if I can pull down the latest I-Build and try it again. If it helps, I'm using JRockit 1.5 on Linux as the JRE. (In reply to comment #3) > Gary, I'll see if I can pull down the latest I-Build and try it again. If it > helps, I'm using JRockit 1.5 on Linux as the JRE. > For legal/IP reasons, I'm only allowed to download certain, pre-approved JVMs, so I am not able to try this out with JRocket. Okay...I'll download the latest source code and step through the debugger to see if I can try and find out why this isn't working. If I find a problem I'll post a patch. I'm going to re-open this as I'm still getting the problem. I tried this under a sun java 1.6 jvm, under linux, and it still gets the same issue. Gary did you try this under linux, or under windows only? I saw this working correctly on Nitin's window machine while at eclipse con, but he saw it not working on my linux machine while there as well. Actually, the preference page dialog is also clickable on Windows, it's just not blocking mouse interaction with the foreground dialog. That's caused by the SWT.APPLICATION_MODAL hint set in the Dialog class being cleared by the FilterDialog's constructor.
public FilterDialog(Shell shell, Validator validator, IProject project){
super(shell);
_shell = shell;
- setShellStyle(SWT.CLOSE|SWT.MIN|SWT.MAX|SWT.RESIZE);
+ setShellStyle(getShellStyle() | SWT.CLOSE|SWT.MIN|SWT.MAX|SWT.RESIZE);
_validator = validator.copy();
_v2 = _validator.asV2Validator();
_project = project;
I can't verify that this will correct the problem on Linux at the moment.
Shouldn't org.eclipse.wst.validation.ui.internal.preferences.ValidationPreferencePage.ValidatorListPage.createPage(Composite) return sc1 instead of _composite?
(In reply to comment #6) > I tried this under a sun java 1.6 jvm, under linux, and it still gets the same > issue. Gary did you try this under linux, or under windows only? > I tried it on Red Hat Linux, using the the IBM Java 5 JVM. I will try it with the SUN, Java 6 JVM as well. Created attachment 93295 [details] patch from comment 7 (In reply to comment #9) > Created an attachment (id=93295) [details] > patch from comment 7 > Verified! That fixed the issue that I was having with the dialog not responding. Bumping severity up to major (I'm tempted to call it blocking). I would say it's blocking as I can't use it at all with out the patch applied. The patch has been applied to HEAD. Thanks for the patch Nitin! released closing |