Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 219218

Summary:

Show attachment preview right after choosing attachment source

Product:

z_Archived

Reporter:

Eike Stepper <stepper>

Component:

Mylyn

Assignee:

Robert Elves <robert.elves>

Status:

RESOLVED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

steffen.pingel

Version:

2.2

Target Milestone:

3.2

Hardware:

OS:

Windows Vista

Whiteboard:

Bug Depends on:

Bug Blocks:

211072

Attachments:

Description	Flags
fix as applied	none
mylyn/context/zip	none

Description Eike Stepper

2008-02-16 04:03:05 EST

I just wanted to attach a patch to a Bugzilla via clipboard and I found that it is not obvious at what time exactly the clipboard data is read.  Wouldn't it be better to read it right after the first step of the attachment wizard and display the attachment preview at that time?

The reason that I stumbled across this is that I tried to copy&paste an attachment comment as well - and got completely confused ;-)

Comment 1 Steffen Pingel

2009-03-30 19:45:10 EDT

*** Bug 270538 has been marked as a duplicate of this bug. ***

Comment 2 Robert Elves

2009-03-30 20:48:39 EDT

Steffen, have you been using the attach in background option?  Is it worth having it around?  Tried moving it to the TaskAttachmentPage but since the connector is only returning the IWizardPage interface, we can't access a new method on the returned page. I could leave it there but it doesn't make much sense when it isn't the last page in the wizard.  Move/remove?

Comment 3 Steffen Pingel

2009-03-30 23:11:34 EDT

Yes, it's not a concern of the connector and should be on one of the generic pages. Why not just leave it on the second page? 

It's too late to remove it. That would be a feature regression (see bug bug 269237).

Comment 4 Robert Elves

2009-04-08 00:43:21 EDT

Created attachment 131203 [details]
fix as applied

Comment 5 Robert Elves

2009-04-08 00:43:26 EDT

Created attachment 131204 [details]
mylyn/context/zip

Comment 6 Robert Elves

2009-04-08 00:54:20 EDT

Fixed.

Comment 7 Steffen Pingel

2009-04-15 14:24:02 EDT

This does not work well when attaching images. Images are displayed as text when the preview page is first openend. I guess the mime type detection hasn't taken place at that point, yet.

Comment 8 Robert Elves

2009-04-22 20:49:43 EDT

Fixed.