Bugzilla – Full Text Bug Listing
| Summary: | [patch][editor] display changes of old -> new values | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Willian Mitsuda <wmitsuda> | ||||||||
| Component: | Mylyn | Assignee: | Jomar Santos <jomaroliversantos> | ||||||||
| Status: | CLOSED MOVED | QA Contact: | |||||||||
| Severity: | enhancement | ||||||||||
| Priority: | P3 | CC: | dveyee, jaxsun.mccarthy, jomaroliversantos, qwang12, rd12hq, sam.davis, steffen.pingel | ||||||||
| Version: | unspecified | Keywords: | plan | ||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| See Also: | https://git.eclipse.org/r/85029 | ||||||||||
| Whiteboard: | |||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 198501 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Willian Mitsuda
Also, display who made the change, so you don't have to open the history just for this. That sounds like a great idea. I would wait designing this though until the notification framework gets an API for the task change deltas (bug 205861) and the task editor is refactored (bug 179254). I really like this idea too and our custom tooltips seem like a great way of implementing it. Then all we need is an affordance to indicate to people that they can hover to see changes. How about we use the little "*" icon that's used by CVS overlays if enabled? BTW, this is a duplicate of enhancement request submitted over a year ago. See bug 171175 *** Bug 171175 has been marked as a duplicate of this bug. *** Out of curiosity, why earlier bug is marked as a duplicate? In general older bugs should be left open and new bugs marked duplicate. However, for the cases where a bug contains considerably more useful information or comments (e.g. the description of this one) we have tended to mark the others a duplicate of that one. Created attachment 203699 [details]
Description part that can open a compare dialog
This changes its background based on outgoing or conflicting state and adds a button to open a compare dialog or editor. It would be good to generalize this to all attribute editors, but this could be used for long text descriptions, which is probably the main use case.
Created attachment 203949 [details]
patch to above file
This fixes a small bug where editing after getting an incoming would incorrectly cause the editor to be marked conflicted.
Sam, could you put these changes into a Gerrit review? I really like the idea of making the changes more prominent a lot as the current affordance for changed attributes is -- to my eyes anyway --hard to pick out. Here you go: https://git.eclipse.org/r/#/c/8828/. Note that you won't see any difference unless you have a repository with editable descriptions (e.g. Accept360). * Attribute editors have a tooltip showing the previous value of the attribute * This could potentially leverage TaskHistory * Rich text editors provide a way to see a diff of the changes, Sam's review may prove a useful starting point New Gerrit change created: https://git.eclipse.org/r/85029 New Gerrit change created: https://git.eclipse.org/r/85029 New Gerrit change created: https://git.eclipse.org/r/85029 Created attachment 265587 [details]
small-magnifying-glass.png
Mylyn has been restructured, and our issue tracking has moved to GitHub [1]. We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub. [1] https://github.com/orgs/eclipse-mylyn |