Bugzilla – Full Text Bug Listing
| Summary: | [DataBinding] Add API: WorkbenchObservables | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Boris Bokowski <bokowski> | ||||||||
| Component: | UI | Assignee: | Boris Bokowski <bokowski> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||
| Severity: | enhancement | ||||||||||
| Priority: | P3 | CC: | fg, mallo.ovidio, qualidafial | ||||||||
| Version: | 3.4 | Keywords: | api, helpwanted | ||||||||
| Target Milestone: | 3.5 M6 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows XP | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Boris Bokowski
No idea if I will have time for this, but if we want it in 3.4, it would have to happen fairly soon. Ran out of time. Don't we have to have a separate bundle with org.eclipse.ui as a dependency first? (In reply to comment #3) > Don't we have to have a separate bundle with org.eclipse.ui as a dependency > first? No - org.eclipse.ui.workbench has a dependency on core.databinding and jface.databinding already. We should put any new API in a separate package though. Frank, quick - which API would you like to see? You have 24 hours for your answer... :-) going once... Created attachment 127983 [details]
patch
going twice... shout if you need more than this.
Created attachment 127986 [details]
better patch
With this patch, you will be able to write (in a view, or an editor):
IObservableValue input = WorkbenchObservables.observeAdaptedSingleSelection(getSite(),IResource.class);
Observables.pipe(input, ViewersObservables.observeInput(myViewer));
Comments or questions?
Matthew, +1? Created attachment 128106 [details]
Patch
Added methods to WorkbenchProperties:
IValueProperty adaptedValue(Class adapter)
IValueProperty adaptedValue(Class adapter, IAdapterManager adapterManager)
Renamed WorkbenchObservables.observeAdaptedValue to observeDetailAdaptedValue since it receives an IObservableValue.
Released to HEAD. |