Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 218355

Summary: [installer] Wrong config.ini for installer on Linux
Product: [Eclipse Project] PDE Reporter: John Arthorne <john.arthorne>
Component: BuildAssignee: pde-build-inbox <pde-build-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: aniefer, kim.moir, pascal
Version: 3.4   
Target Milestone: 3.6 M6   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch for option 3 none

Description John Arthorne CLA 2008-02-08 13:38:46 EST 
The config.ini file for the p2 installer download on Linux has the win32 SWT fragment listed. Presumably the Mac installer has the same problem.  Andrew N, can you confirm again that the correct answer is to list all SWT fragments in my config.ini?
Comment 1 Andrew Niefer CLA 2008-02-08 14:41:37 EST 
The current .product build is not designed for platform specific config.ini files.

We have a couple of options
1) List all the swt fragments in the config.ini file, I believe this will work, but will result in error messages to the log for each fragment not found.

2) provide N copies of the config.ini file, one per platform, and change the build script to get the correct one.  (Could perhaps be done by having a feature.build.properties containing root properties and that is specified to the generated feature.)

3) Use a token in the config.ini file that gets replaced by the build script.  See attached patch for an example of this.
Comment 2 Andrew Niefer CLA 2008-02-08 14:44:51 EST 
Created attachment 89299 [details]
patch for option 3

untested patch implementing option 3
Comment 3 John Arthorne CLA 2008-02-13 18:00:09 EST 
The other option is that the installer is created by a p2 director operation. p2 would know what bundles to include based on platform filters on the profile. Pascal, is it feasible to do this in 1.0? The installer has no configurator - it just lists all bundles in config.ini.
Comment 4 Andrew Niefer CLA 2008-02-13 18:10:42 EST 
See bug 218878 and bug 218623.  The possibility exists to generate a product IU for the p2 installer based on the product file.
Comment 5 Pascal Rapicault CLA 2008-02-13 21:21:22 EST 
As long as the product IU does not brings in simpleconfigurator, simple configurator will not be included and the proper config.ini will be created (at least this is one of the promise of fwk admin)

Andrew if you need a real life example, you may want to use the installer as a test application.
Comment 6 Andrew Niefer CLA 2010-03-05 16:29:46 EST 
The installer is using a product file without a custom config.ini. 

 PDE/Build is creating a product with a bundles.info that contains all the bundles. 

I think this is now a PDE/Build bug, we should be creating bundles.info files containing only the bundles that match the platform.
Comment 7 Andrew Niefer CLA 2010-03-05 17:00:36 EST 
PDE/Build is fixed for M6.  The installer will be fine whenever releng updates the basebuilder.