Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 217747

Summary: Fatal Error on local copy of Phoenix
Product: Community Reporter: Gabe O'Brien <gabe.obrien>
Component: WebsiteAssignee: phoenix.ui <phoenix.ui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: gunnar
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Fixes a Fatal error I get on my local box from menu.php none

Description Gabe O'Brien CLA 2008-02-04 15:54:42 EST
Created attachment 88825 [details]
Fixes a Fatal error I get on my local box from menu.php

The Babel server tool uses Phoenix.  On my local box I get an Fatal error from line 23.  The fix is simple and a patch in included with this bug.

Thanks,
gO'
Comment 1 Denis Roy CLA 2008-05-07 18:51:28 EDT
Hrm, moving to community/website.  EPIC is for www.eclipseplugincentral.com specifically.
Comment 2 Denis Roy CLA 2008-05-07 18:58:55 EDT
Thanks for the patch.

As isset() returns a bool, I've changed 

if(isset($App->PageRSS) != "") 

to:

if(isset($App->PageRSS)) {
	if($App->PageRSS != "") {
		$pageRSS = $App->PageRSS;
}


menu.php > 1.17
Comment 3 Gabe O'Brien CLA 2008-05-07 19:07:04 EDT
Thanks for taking my patch and improving it.  How many more patches do I have to submit before I can become a real Phoenix developer?
Comment 4 Denis Roy CLA 2008-05-07 20:57:56 EDT
Um, I dunno, our standards are pretty high....

You need to break eclipse.org at least once to prove your worthiness.  Come on, we've all done it, so can you.
Comment 5 Gunnar Wagenknecht CLA 2008-05-08 02:10:07 EDT
(In reply to comment #3)
> Thanks for taking my patch and improving it.  How many more patches do I have
> to submit before I can become a real Phoenix developer?

How many patches did you provide via Bugzilla? Note, the Portal patches don't count as it's not an Eclipse project. :P