Bugzilla – Full Text Bug Listing
| Summary: | open task dialog should filter according to the currently active task working set | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Eugene Kuleshov <ekuleshov> | ||||||||||
| Component: | Mylyn | Assignee: | Willian Mitsuda <wmitsuda> | ||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||
| Severity: | enhancement | ||||||||||||
| Priority: | P4 | CC: | mik.kersten, steffen.pingel, wmitsuda | ||||||||||
| Version: | unspecified | Keywords: | helpwanted, noteworthy | ||||||||||
| Target Milestone: | 2.3 | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | All | ||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Eugene Kuleshov
Willian: any interest in this? Working set filtering is pretty straightforward, let me know if you want a pointer. OK, I can take a look. I recently decided to give another try to working sets. Some quick questions, just to confirm: 1 - Can I rely on TaskListView.getActiveWorkingSets() as a central point to obtain the set of task working sets? 2 - Can I assume that if the returned value is empty, there are no working sets selected? Can you please also allow to turn off and/or manually select working set similarly how it is done by the Open Type dialog. I think it is safe to assume that TaskListView.getActiveWorkingSets() as an access point for an active working set info. You can look at the implementation to see where the working sets came from and how it is calculated. So yes, if returned collection is empty there is no task working set selected. Created attachment 88642 [details]
Initial patch for testing purposes
Thanks Eugene. Can you experiment with this patch and see if it looks like what you wanted?
I included a check action (enabled by default) to filter according to the task working set configuration. It is possible to turn off, and the configuration is sticky and shared among the dialog instances, so it will work for open, activate and copy context.
I'm not sure if it is worth to mimic the open type dialog, letting the user choose working sets other than the window working set. I find it particularly too much complex.
Created attachment 88643 [details]
mylyn/context/zip
This look great. I'd suggest to rename "Filter by Active Working Set" to just "Active Working Set", maybe add working set icon and put a menu separator before it (so it will look similar to what "Open Type" dialog has) Another thing that would be handy is to show existing task working sets in the dialog menu to quickly flip between them. Maybe you could reuse code from TaskWorkingSetAction.addActionsToMenu() (In reply to comment #7) > Another thing that would be handy is to show existing task working sets in the > dialog menu to quickly flip between them. Maybe you could reuse code from > TaskWorkingSetAction.addActionsToMenu() Do you think it is better to make the dialog selection update the window working set, like in task list view, or just populate the working set list on dialog opening and have the menu operate on this temporary list? (In reply to comment #8) > Do you think it is better to make the dialog selection update the window working > set, like in task list view, or just populate the working set list on dialog > opening and have the menu operate on this temporary list? I would say that open task dialog should not change global active working set. That is how "Open Type" dialog works and it seem a good idea to use it as reference. Created attachment 89058 [details]
Patch
Complete implementation.
I decided it's better to mimic the open type/resource dialog, since it would be more familiar for users.
Created attachment 89059 [details]
mylyn/context/zip
Mik, please consider this for 2.3. Great work, thanks Willian! I merged the patch and updated the IP log. Strictly speaking we are passed the feature dead line but I have been running with the patch for a while and not encountered any problems. It's a useful addition and makes the functionality of the open task dialog consistent with similar dialogs in platform. Willian, it would be great if you could respond to bugs in case any problems are discovered with the working set selection before the 2.3 release. OK, thanks for applying! |