| Summary: | [Platform Project] Remove duplicate/unused messages | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Paul Slauenwhite <paulslau> | ||||||||
| Component: | TPTP | Assignee: | Ritwik Lodhiya <ritwikl> | ||||||||
| Status: | CLOSED DUPLICATE | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P1 | CC: | apnan, jkubasta, lizdancy, ritwikl | ||||||||
| Version: | unspecified | Flags: | jkubasta:
review?
(mmostafa) jkubasta: review? (apnan) jkubasta: review? (ewchan) jkubasta: review? (analexee) paulslau: review- |
||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Paul Slauenwhite
(In reply to comment #0) Correction: org.eclipse.tptp.platform.analysis.codereview.java: org.eclipse.tptp.platform.analysis.codereview.java.analysismarker template_field_ARGCOUNT template_field_METHOD template_field_CLASS By copy to Ritwik, does this match what you saw yesterday? Created attachment 88481 [details]
Cleanup Patch
This patch cleans up all the unused strings from the platform directory under HEAD.
Created attachment 88593 [details]
Patches for all Projects under HEAD
Cleanup patches for the projects under HEAD.
please review the patch and ensure you approve of the messages being removed Liz, if you have a spare minute would you mind advising re probekit? thx Several of the Strings identified under org.eclipse.hyades.probekit.ui: for example, _UI_Target_type_feature are called using their ID in other parts of the code. These cannot be removed but can be re-packaged to adhere to the comment posted by Paul below (about which Strings belong in the .properties file for a plug-in). This also applies to the Strings under org.eclipse.hyades.probekit. However, when I apply the patch these don't appear to be removed so it should be safe as written but please confirm. Also, please update the copyright year for the files edited. Thanks Ritwik! The review should be completed by the component leads for these components. The Test Project plug-ins have already been updated. Created attachment 91379 [details]
Updates Copyrights on Monitoring, Platform, Test, and Trace
Many of the files had their copyrigt updated since the last patches. Hopefully this covers the rest =).
Please note: I have updated the cleanup for the Trace Project. It is the latest attachment in Bug# 216575 - Link: https://bugs.eclipse.org/bugs/show_bug.cgi?id=216575 *** This bug has been marked as a duplicate of bug 212037 *** Closing since same originator for both this defect and the dependent defect. |