Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 216322

Summary: Remove org.eclipse.help.appserver from the platform feature
Product: [Eclipse Project] Platform Reporter: Chris Goldthorpe <cgold>
Component: RelengAssignee: John Arthorne <john.arthorne>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: jeffmcaffer, john.arthorne, kim.moir, Mike_Wilson
Version: 3.4Flags: Mike_Wilson: pmc_approved+
Target Milestone: 4.1 M3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 216328    
Bug Blocks:    
Attachments:
Description Flags
patch for releng project and platform feature
none
patch
none
Patch v2 none

Description Chris Goldthorpe CLA 2008-01-23 13:45:02 EST 
The platform feature org.eclipse.platform-feature/feature.xml should remove the reference to the plugin org.eclipse.help.appserver .

org.eclipse.help.appserver is not used by the help system or by any other part of Eclipse, it was not in use in Eclipse 3.3 either. It is legacy code from the days when we used the Tomcat server. We should remove this plugin from the platform feature.
Comment 1 Kim Moir CLA 2008-01-23 14:10:25 EST 
Created attachment 87685 [details]
patch for releng project and platform feature
Comment 2 Kim Moir CLA 2008-01-29 13:03:33 EST 
I think you need to to add pmc member as a cc so an email is sent requesting approval on this bug.
Comment 3 Mike Wilson CLA 2008-01-29 14:37:48 EST 
Jeff, do you have any thoughts about this?
Comment 4 Jeff McAffer CLA 2008-02-01 21:02:01 EST 
I do have some concerns that this will disrupt some folks.  In essence the signature of a feature is the bundles it supplies.  Whether or not the appserver bundle was API it may still be missed.  Having said that, I believe that we have in the past removed things like Xerces and Tomcat.  With the assurance that appserver really has nothing in it that people could be using I would agree to its removal.  Otherwise, removing it does not fit in the "stability" theme of  3.4
Comment 5 Chris Goldthorpe CLA 2008-02-04 13:11:09 EST 
I'm thinking that we should probably defer this to 4.0. This is not an important change so if we have concerns we should hold back.
Comment 6 Mike Wilson CLA 2008-02-04 14:47:23 EST 
seems like a good plan.
Comment 7 Kim Moir CLA 2010-10-01 16:44:58 EDT 
Created attachment 180089 [details]
patch

Patch for R4_HEAD version of platform feature currently used for 4.1 builds.  Will cc John to release it.
Comment 8 Kim Moir CLA 2010-10-01 16:45:52 EDT 
John, this is a patch to remove the appserver bundle from the R4_HEAD version of the feature which is used in 4.1 builds.
Comment 9 John Arthorne CLA 2010-10-04 10:17:28 EDT 
Created attachment 180169 [details]
Patch v2

The platform feature is stored in a different place in the 4.x stream.
Comment 10 John Arthorne CLA 2010-10-04 10:21:44 EDT 
Released in R4_HEAD