Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 216263

Summary: [filters] Java Output Folder filter in the Project Explorer
Product: [Eclipse Project] JDT Reporter: Kaloyan Raev <kaloyan>
Component: UIAssignee: JDT-UI-Inbox <jdt-ui-inbox>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: cbridgha, daniel_megert, david_williams, martinae
Version: 3.4   
Target Milestone: 3.4 M5   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch none

Description Kaloyan Raev CLA 2008-01-23 07:11:54 EST
Created attachment 87632 [details]
patch

The Package Explorer view in the JDT perspective filters the output folders of the Java projects. This filtering is done on JavaModel level. 

The Web Tools Platform project uses the Project Explorer view in the Java EE perspective. The latter view is not based on the JavaModel and the output folders are not filters. There is also no filter that the user can enable to do the filtering. 

Looking at the jdt.ui code I have found that there is a filter already implemented: org.eclipse.jdt.internal.ui.filters.OutputFolderFilter. But the filter is not registered as such in the Project Explorer. 

The proposed patch registers the OutputFolderFilter in the Project Explorer. By, default the filter is enabled.
Comment 1 Dani Megert CLA 2008-01-23 08:05:03 EST
David, do you see any problem for WTP when we add this filter as enabled per default?

I would change name of the filter to 'Java output folders'.
Comment 2 David Williams CLA 2008-01-28 08:32:05 EST
Seems like a good idea to me. And, 'enabled' means folders are not shown (by default), right? That would be correct. 

I'm adding Chuck to CC in case he knows of some complication. 

Comment 3 Dani Megert CLA 2008-01-28 08:34:08 EST
> 'enabled' means folders are not shown
Yep.
Comment 4 Martin Aeschlimann CLA 2008-01-31 06:32:00 EST
released > 20080131
Comment 5 Kaloyan Raev CLA 2008-02-04 10:33:18 EST
I have verified with the N20080202-0010 build. 

The filter is there and works as expected. The filter's name is still "Output folders" (as in my patch) instead of "Java output folders" (as Daniel suggests to change it). 
Comment 6 Dani Megert CLA 2008-02-05 03:46:24 EST
Adjusted filter name in HEAD for M5.
Comment 7 Dani Megert CLA 2008-02-07 03:36:17 EST
Verified in I20080206-1800.
Comment 8 Kaloyan Raev CLA 2008-05-29 12:55:32 EDT
Closing