Bugzilla – Full Text Bug Listing
| Summary: | [Dialogs] FilteredItemsSelectionDialog should respect setInitialSelections() | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Eric Rizzo <eclipse-bugs> |
| Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | emmanuel.chebbi, hannes, karsten.thoms |
| Version: | 3.4 | ||
| Target Milestone: | 4.14 M3 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://git.eclipse.org/r/150637 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=3e49f9ea3130e7ba80887b4638db2bfe6eb18360 |
||
| Whiteboard: | |||
|
Description
Eric Rizzo
I believe this goes to Tod as an IDE/Dialog bug. As Francis Upton states on http://www.eclipsezone.com/eclipse/forums/t105252.html , there is an ugly workaround: use setInitialPattern() and set the pattern to the text of the element-to-select. This of course won't work with more than one item to select; and even with a single initial selection element you need to make sure that the sorting of the items is so that it always selects the right element, e.g. with elements foo foobar foofoobar the initial selection of "foo" only works when the elements are sorted by normal string comparison. Is there a chance this is going to be fixed/improved? At least some documentation (eg. "throw new UnsupportedOperationException()" for those unsupported operations) would be nice. Thanks! (In reply to comment #3) > > Is there a chance this is going to be fixed/improved? > At least some documentation (eg. "throw new UnsupportedOperationException()" > for those unsupported operations) would be nice. Thanks! > If you submit a patch (with a test case) I will give it a 3.6 milestone to review it. Otherwise it's unlikely to happen. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. I can confirm that the bug is not fixed. I implemented the feature and will submit a patch as soon as I have implemented a few tests. (In reply to Emmanuel Chebbi from comment #6) > I can confirm that the bug is not fixed. Thanks for confirming. It is always hard to tell for old bugs if they are still relevant. > > I implemented the feature and will submit a patch as soon as I have > implemented a few tests. That'll be awesome! Please raise your voice when you need guidance for the contribution process. New Gerrit change created: https://git.eclipse.org/r/150637 > Please raise your voice when you need guidance for the contribution process.
Thank you very much! I just submitted a new Gerrit change but since it's my first time I am not quite confident about what comes next. Review comments are made directly on Gerrit, right?
Yes, feedback on a specific change is done on Gerrit. Here the issue itself and how to reproduce it is discussed. Gerrit change https://git.eclipse.org/r/150637 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=3e49f9ea3130e7ba80887b4638db2bfe6eb18360 Thanks Emmanuel for your conntribution! |