Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 213384

Summary: logParser extension contributed by a plugin is not shown in import wizard
Product: z_Archived Reporter: Dave Smith <smith>
Component: TPTP.monitoringAssignee: Rohit Shetty <rohit.shetty>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P1 CC: apnan
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: PC   
OS: Windows 2000   
Whiteboard: closed460
Attachments:
Description Flags
Parser plugin that shows failure
none
Parser plugin that shows failure
none
Patch to fix this problem.
none
Test suite none

Description Dave Smith CLA 2007-12-18 18:16:55 EST 
If a TPTP extender creates a plugin that contains logParser extensions with a parser set that is a child of another parser set, the log parsers may not be displayed in the Log Import wizard log type list.  

There is a bug in the org.eclipse.tptp.monitoring.logui.internal.wizards.LogSetManager.loadParserSetRegistry() method.  If the parent parser set is not loaded before the child parser set is loaded, the child parser set and the parsers contained in that parser set will not be included in the log type list in the wizard.
Comment 1 Dave Smith CLA 2007-12-18 18:18:26 EST 
Increasing the severity because it limits the extensibility of LTA.
Comment 2 Alex Nan CLA 2007-12-18 18:22:20 EST 
Targetting to M5  since it's not a stopper for M4.
Comment 3 Dave Smith CLA 2007-12-19 01:36:08 EST 
Created attachment 85532 [details]
Parser plugin that shows failure

This parser plug-in includes a logParser extension that is not shown in the log type list of the log import wizard
Comment 4 Dave Smith CLA 2007-12-19 01:49:27 EST 
Created attachment 85533 [details]
Parser plugin that shows failure

This parser plug-in includes a logParser extension that is not shown in the log type list of the log import wizard.
Comment 5 Dave Smith CLA 2007-12-19 01:56:02 EST 
Created attachment 85535 [details]
Patch to fix this problem.

You may want to change the fix to be more efficient.
Comment 6 Alex Nan CLA 2008-01-08 15:11:05 EST 
Rohit, please take a look at this.
Comment 7 Rohit Shetty CLA 2008-01-12 05:46:51 EST 
The attached patch looks good and works perfectly.
Comment 8 Rohit Shetty CLA 2008-01-12 06:00:46 EST 
Created attachment 86757 [details]
Test suite
Comment 9 Rohit Shetty CLA 2008-01-12 06:02:58 EST 
Fix is in CVS.
Comment 10 Paul Slauenwhite CLA 2009-06-30 09:55:28 EDT 
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.