Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 213329

Summary:	Importing large datapool freezes wizard.
Product:	z_Archived	Reporter:	Paul Slauenwhite <paulslau>
Component:	TPTP	Assignee:	Paul Slauenwhite <paulslau>
Status:	CLOSED FIXED	QA Contact:
Severity:	major
Priority:	P1	CC:	jerome.bozier
Version:	unspecified	Keywords:	plan
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:
Bug Blocks:	185878

Description Paul Slauenwhite

2007-12-18 12:14:26 EST

Importing large datapool freezes wizard.

Running the 'Test with Sample CSV files' test case in org.eclipse.hyades.test.ui.datapool.tests\manual\datapool\Test.UI.DatapoolEditor_importExport.testsuite causes the import wizard to hang indefinitely.  The verification step in the wizard should be removed.

Jerome B, please investigate.

Comment 1 Paul Slauenwhite

2008-01-30 12:14:30 EST

Deferred from I5 to I6 with PMC approval.

Comment 2 Paul Slauenwhite

2008-03-05 08:59:28 EST

This verification step is necessary to validate the CVS file and should should not be removed.  After a closer inspection, the validation code in org.eclipse.hyades.test.ui.datapool.internal.util.CSVImportExportUtil.validateCSVFile(String, boolean, boolean, String) was poorly written.  This method has been completely rewritten to be more performant (e.g. user does not see any different in the UI when validating a datapool with 1 or 65,000 records) and with better error handling (e.g. evaluates all conditions for valid CSV file).  

The following files checked into CVS (HEAD):

org.eclipse.hyades.test.ui.datapool.internal.util.CSVImportExportUtil.java
org.eclipse.hyades.test.ui.datapool.internal.util.CSVTokenizer.java
org.eclipse.hyades.test.ui.internal.resources.UiPluginResourceBundle.java
/org.eclipse.hyades.test.ui/src/org/eclipse/hyades/test/ui/internal/resources/messages.properties

Comment 3 Paul Slauenwhite

2008-06-10 09:59:56 EDT

Verified in TPTP-4.5.0-200806070100.  Closing.