Bugzilla – Full Text Bug Listing
| Summary: | New Plug-in Project wizard is humongous | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Wassim Melhem <wassim.melhem> | ||||||||
| Component: | UI | Assignee: | Curtis Windatt <curtis.windatt.public> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | baumanbr, caniszczyk, curtis.windatt.public, remy.suen | ||||||||
| Version: | 3.4 | Flags: | curtis.windatt.public:
review?
(caniszczyk) |
||||||||
| Target Milestone: | 3.4 M5 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows XP | ||||||||||
| Whiteboard: | |||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 208945 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Wassim Melhem
(In reply to comment #0) > Execution Environment should probably be moved to the second page and be placed > among the other manifest.mf settings I thought there was a bug open for this already but I could be wrong. I'll look at this. At the same time I'll fix a bug I found in my fix for bug 204924 where the EE enablement isn't updated when switching from Eclipse Version to OSGi Framework. Are you suggesting the the Target Environment Group be moved from the one page to the other after the Plug-In Options group? Alternatively, if the EE is not going to be set, I could make the group invisible rather than just disabling it. The Rich Client Application group is made invisible, while the Plug-In Options group is simply disabled (based on whether a Simple vs Java project is chosen). Curtis, the EE is just another property. I am not sure we need a dedicated section to it. It feels that it should be part of the 'Plug-in Properties' group. (In reply to comment #4) > Curtis, the EE is just another property. I am not sure we need a dedicated > section to it. It feels that it should be part of the 'Plug-in Properties' > group. > I was thinking the same thing, hence why I asked :) Will do. Created attachment 85475 [details]
Patch for review
Patch moves removed the environment group from the initial page and adds the setting to the plug-in properties group on the second page.
The first page is no longer humongous :)
Brian please review. Unless Wassim is able to? Found a problem while looking at bug 208945. In method PluginContentPage#updateData() the execution environment is set if the combo box is enabled. However, it isn't cleared if the EE is not set. This might not normally a problem because if the combo was disabled, the execution environment should be used. But once setting the EE is optional (bug 208945), it will be a problem. So we should add an else part } else { fData.setExecutionEnvironment(null); } In addition, we have to change NewProjectCreationOperation#getClassPathEntries(project, data) to handle a possibly null EE. I'm not sure how to deal with it. *** Bug 208895 has been marked as a duplicate of this bug. *** I will have to update the patch because the EE Combo was changed as part of bug 213750. I'll also make the changes from comment #8. Created attachment 86000 [details]
Updated patch
Thanks Curtis! We have to keep Wassim quiet :) Created attachment 86020 [details]
mylyn/context/zip
Thanks Curtis for your work on this and thanks Chris for keeping things moving smoothly. You guys are great ;-) Verified on I20080204-0800 |