Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 213240

Summary: Missing Alt tags in Report Selection Page
Product: z_Archived Reporter: Liz Dancy <lizdancy>
Component: TPTPAssignee: Ritwik Lodhiya <ritwikl>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P1 CC: apnan, jacalcat, jkubasta
Version: unspecifiedKeywords: plan
Target Milestone: ---Flags: apnan: review+
Hardware: PC   
OS: Windows XP   
Whiteboard: closed460
Attachments:
Description Flags
Proposed patch none

Description Liz Dancy CLA 2007-12-17 17:27:57 EST
ReportHTMLLogWizardSelectionPage is missing Alt Tags for accessibility. This is being opened to address the TPTP side of an AC defect which was opened as blocking due to accessibility.
Comment 1 Paul Slauenwhite CLA 2007-12-19 15:03:45 EST
Decreasing severity since the page is still fucntional.
Comment 2 Paul Slauenwhite CLA 2007-12-20 06:24:26 EST
Accessibility tags that show up when you press alt (they underline one letter so you can navigate to that widget using the alt + letter on the keyboard).
Comment 3 Paul Slauenwhite CLA 2008-02-04 07:08:50 EST
Joanna, I believe this defects was mistakenly assigned to me since it is for the Log Reporting Wizard and not the BIRT reporting framework.  Transferring to you to reassign.
Comment 4 Ritwik Lodhiya CLA 2008-02-13 15:27:24 EST
Created attachment 89679 [details]
Proposed patch

This patch adds the shortcuts to the inaccessible page =).
Comment 5 jkubasta CLA 2008-02-13 19:56:12 EST
Alex, would you please review the proposed patch? Thanks.
Comment 6 Alex Nan CLA 2008-02-26 16:29:51 EST
Yes, it looks good. 
I've also added and extra mnemonic to the string 
_156     = &Select the Report to be created:

in

org.eclipse.tptp.platform.common.ui\src-common-internal\org\eclipse\tptp\platform\common\ui\internal\messages.properties.
I've checked in the patch. Please mark the defect as being fixed.
Thanks.
Comment 7 jkubasta CLA 2008-02-26 16:38:34 EST
Resolving as fixed.  Thanks Ritwik and Alex.
Comment 8 Paul Slauenwhite CLA 2009-06-30 10:30:48 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since the originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.