Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 212839

Summary: [registers] Register view should have a type column.
Product: [Tools] CDT Reporter: Pawel Piech <pawel.1.piech>
Component: cdt-debug-dsfAssignee: Randy Rohrbach <Randy.Rohrbach>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: cdtdoug, dd.general-inbox
Version: 0 DD 1.0   
Target Milestone: DD 1.0   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch with fix. cdtdoug: iplog-

Description Pawel Piech CLA 2007-12-12 23:13:40 EST 
The registers view currently does not have a type column, although if a register is shown in the expressions view, it does populate the label in this view.  However, currently the value shown in the type column for a register is a combination of whether the register is a float as well as whether it's Read/Write, etc.  

CDI/MI is capable of dispalying the type of the value stored in the register, such as: void*, int, union, etc.  This capability should be added to the DSF registers view for feature parity.  

Adding this feature will also require changing the IRegisters.IRegisterDMData interface to include a type string.  To accomodate different back ends, the IRegisterDMData.getType() could return a null value, in which case the type string could be composed using the current method.
Comment 1 Pawel Piech CLA 2007-12-12 23:14:15 EST 
See also bug 159693 comment 14
Comment 2 Pawel Piech CLA 2008-04-18 16:18:51 EDT 
Created attachment 96658 [details]
Patch with fix.
Comment 3 Pawel Piech CLA 2008-04-18 16:19:44 EDT 
I added the type column.  Randy please review.
Comment 4 Randy Rohrbach CLA 2008-04-22 11:03:33 EDT 
Pawel

   The "Type" field seems to be added properly. I did not see anything
   added to fill it in and the services changes needed. I assume you
   are waiting for 1.1 to do this.

Randy
Comment 5 Pawel Piech CLA 2008-04-22 12:46:43 EDT 
(In reply to comment #4)
Strangely enough the RegistersVMNode and the services already have support for this column because it is used in the Expressions view.  Although the change to IRegisterDMData was not necessary, since the type string is generated based on other information (unsigned vs. float and read/write).
Comment 6 Pawel Piech CLA 2008-08-13 13:06:34 EDT 
Closing out 1.0 bugs.