Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 212708

Summary: [prov] [ui] Failure of background update checker should be silent
Product: [Eclipse Project] Equinox Reporter: John Arthorne <john.arthorne>
Component: IncubatorAssignee: Susan McCourt <susan>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: pascal, susan
Version: 3.4   
Target Milestone: 3.4 M6   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description John Arthorne CLA 2007-12-11 23:33:15 EST
Build: I20071211-0954

 - I was working disconnected for awhile this evening. Every once in awhile I got an error dialog popup saying "Error during phase collect", with a similar wad in the log file:

!ENTRY org.eclipse.equinox.p2.engine 4 0 2007-12-11 17:20:42.859
!MESSAGE 
!SUBENTRY 1 org.eclipse.equinox.p2.engine 4 8 2007-12-11 17:20:42.859
!MESSAGE Error during phase: collect.
!SUBENTRY 2 org.eclipse.equinox.p2.download 4 0 2007-12-11 17:20:42.859
!MESSAGE 
!SUBENTRY 3 org.eclipse.equinox.p2.artifact.repository 4 0 2007-12-11 17:20:42.859
!MESSAGE No repository found containing: org.eclipse.cvs.source/eclipse/plugin/1.0.100.v20070824-7C79Do9EI99hAWDX

If the background update check can't proceed, it should fail silently and retry later. Being disconnected from the network is not an error.
Comment 1 Pascal Rapicault CLA 2007-12-12 09:46:26 EST
Marking as a UI bug because the presentation of the errors is done there.
Comment 2 Susan McCourt CLA 2008-01-31 19:42:39 EST
Moving these to M6.  I think it's better to test now than start tackling the error reporting problem.  I intend to work on this during "dead time" at the end of M5 because these are important for SDK integration.
Comment 3 Susan McCourt CLA 2008-02-13 14:12:39 EST
All failures in the background update checker are now only logged (not shown in a dialog).  That handles the UI part.

John also said, 
>Being disconnected from the network is not an error.

If the engine gives me a Status that is an ERROR, then I will log it as an error.  Not much I can do about that. Also, when I get ProvisionExceptions, I report them as errors.