Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 212613

Summary: [prov] Update wizard doesn't close on restart
Product: [Eclipse Project] Equinox Reporter: John Arthorne <john.arthorne>
Component: p2Assignee: P2 Inbox <equinox.p2-inbox>
Status: RESOLVED WORKSFORME QA Contact:
Severity: normal    
Priority: P3 CC: pascal, susan
Version: 3.4   
Target Milestone: ---   
Hardware: PC   
OS: Windows Vista   
Whiteboard:

Description John Arthorne CLA 2007-12-11 12:06:18 EST
Build: I20071211-0954

 - Installed SDK, userui, and releng.tools into a new profile
 - After running for awhile, I was prompted that updates were available. I
clicked to proceed with the update.
 - The update wizard opened. I just clicked "Finish" to install everything.
 - I got a new dialog on top of the wizard dialog, prompting for restart. I clicked "Ok" to proceed with the restart
 - The restart dialog and the workbench window closed, but the update wizard was left open. I clicked "Finish" again, and finally the wizard closed and Eclipse exited.

-> The wizard should close after clicking Finish button the first time.
Comment 1 Susan McCourt CLA 2007-12-11 13:51:40 EST
John, were there any failures reported or logged during the update?
It sounds as if something went wrong during the update.

Under "normal circumstances" 
- select a couple of roots that need updating
- choose the items from the list that are the real updates 
(vs. the old ones bogusly presented due to bug #212609)
- click update...

I observe that the update completes and the wizard closes before the restart dialog ever shows up.  

I'm thinking there was some failure condition that contributed to this scenario, causing the wizard to fail in the middle of the finish process and remain open.
Comment 2 Susan McCourt CLA 2007-12-11 14:04:33 EST
I think that the failure condition that causes the UI to end up in this state is something like bug #208470.  I don't observe dialogs hanging open if I'm doing the update from the agent (non-self profile), but I suspect that this occurs when the failure occurs on the self profile (I'm reinstalling my self hosting SDK in order to confirm this).
Comment 3 John Arthorne CLA 2007-12-11 14:32:17 EST
I didn't get any failure messages, and there were no messages in the log. However, the install certainly failed. After closing the wizard, the restart failed, and the profile is clearly in a broken state and cannot be restarted.
Comment 4 Pascal Rapicault CLA 2008-06-12 21:04:39 EDT
Closing as I don't think this is an issue anymore.